Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: gni/v8.gni

Issue 2373783002: [build] Link V8 as component in static library builds (Closed)
Patch Set: Review Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build_overrides/v8.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gni/v8.gni
diff --git a/gni/v8.gni b/gni/v8.gni
index d2b4da825e630887619d6e84757b3f51b1fb60dd..8dc9a25d4266ded65afd5a81823507b0211feeed 100644
--- a/gni/v8.gni
+++ b/gni/v8.gni
@@ -87,11 +87,20 @@ if (is_posix && v8_enable_backtrace) {
# All templates should be kept in sync.
template("v8_source_set") {
- source_set(target_name) {
- forward_variables_from(invoker, "*", [ "configs" ])
- configs += invoker.configs
- configs -= v8_remove_configs
- configs += v8_add_configs
+ if (defined(v8_static_library) && v8_static_library) {
+ static_library(target_name) {
+ forward_variables_from(invoker, "*", [ "configs" ])
+ configs += invoker.configs
+ configs -= v8_remove_configs
+ configs += v8_add_configs
+ }
+ } else {
+ source_set(target_name) {
+ forward_variables_from(invoker, "*", [ "configs" ])
+ configs += invoker.configs
+ configs -= v8_remove_configs
+ configs += v8_add_configs
+ }
}
}
« no previous file with comments | « build_overrides/v8.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698