Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(115)

Issue 23737004: Paint flex items atomically, like inline-blocks (Closed)

Created:
7 years, 1 month ago by cbiesinger
Modified:
7 years, 1 month ago
Reviewers:
ojan
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, Julien - ping for review
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -19 lines) Patch
A LayoutTests/css3/flexbox/mozilla/flexbox-items-as-stacking-contexts-2.html View 1 chunk +82 lines, -0 lines 0 comments Download
A LayoutTests/css3/flexbox/mozilla/flexbox-items-as-stacking-contexts-2-expected.html View 1 chunk +64 lines, -0 lines 0 comments Download
M Source/core/rendering/InlineBox.cpp View 1 chunk +2 lines, -18 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 1 chunk +32 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderFlexibleBox.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
cbiesinger
7 years, 1 month ago (2013-08-29 23:27:01 UTC) #1
ojan
lgtm https://codereview.chromium.org/23737004/diff/1/Source/core/rendering/RenderBlock.cpp File Source/core/rendering/RenderBlock.cpp (right): https://codereview.chromium.org/23737004/diff/1/Source/core/rendering/RenderBlock.cpp#newcode3124 Source/core/rendering/RenderBlock.cpp:3124: // Paint all phases of replaced elements atomically, ...
7 years, 1 month ago (2013-08-29 23:46:05 UTC) #2
cbiesinger
https://codereview.chromium.org/23737004/diff/1/Source/core/rendering/RenderBlock.cpp File Source/core/rendering/RenderBlock.cpp (right): https://codereview.chromium.org/23737004/diff/1/Source/core/rendering/RenderBlock.cpp#newcode3124 Source/core/rendering/RenderBlock.cpp:3124: // Paint all phases of replaced elements atomically, as ...
7 years, 1 month ago (2013-08-30 17:33:50 UTC) #3
cbiesinger
cc'ing jchaffraix because I think grid needs a similar change
7 years, 1 month ago (2013-08-30 17:34:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbiesinger@chromium.org/23737004/6001
7 years, 1 month ago (2013-08-30 17:35:05 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-08-30 19:04:54 UTC) #6
Message was sent while issue was closed.
Change committed as 157004

Powered by Google App Engine
This is Rietveld 408576698