Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2373683003: Remove som GYP annotations, remove unused manifest. (Closed)

Created:
4 years, 2 months ago by brettw
Modified:
4 years, 2 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, chromoting-reviews_chromium.org, scheib+watch_chromium.org, ortuno+watch_chromium.org, dmazzoni+watch_chromium.org, agrieve+watch_chromium.org, extensions-reviews_chromium.org, aboxhall+watch_chromium.org, jam, je_julie, darin-cc_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, android-webview-reviews_chromium.org, mlamouri+watch-content_chromium.org, Peter Beverloo, yuzo+watch_chromium.org, piman+watch_chromium.org, jochen+watch_chromium.org, nektar+watch_chromium.org, jbudorick+watch_chromium.org, mikecase+watch_chromium.org, dtseng+watch_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove som GYP annotations, remove unused manifest. Removes annotations of "GYP version" from GN targets. Removes shell.exe.manifest which was used only by the GYP build. TBR=dpranke@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/cde1af7bd0ccf5b051bd3bac47290e15d8a0ef29 Cr-Commit-Position: refs/heads/master@{#421335}

Patch Set 1 #

Patch Set 2 : More #

Patch Set 3 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -192 lines) Patch
M android_webview/test/BUILD.gn View 7 chunks +0 lines, -7 lines 0 comments Download
M android_webview/tools/system_webview_shell/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M base/BUILD.gn View 9 chunks +0 lines, -13 lines 0 comments Download
M base/android/jni_generator/BUILD.gn View 4 chunks +0 lines, -4 lines 0 comments Download
M base/android/linker/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M base/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/device/commands/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/remote/device/dummy/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/rezip/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M build/buildflag_header.gni View 1 chunk +0 lines, -1 line 0 comments Download
M build/secondary/third_party/android_tools/BUILD.gn View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chromecast/BUILD.gn View 1 3 chunks +0 lines, -3 lines 0 comments Download
M chromecast/android/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/app/BUILD.gn View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chromecast/base/BUILD.gn View 1 5 chunks +0 lines, -5 lines 0 comments Download
M chromecast/base/component/BUILD.gn View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chromecast/browser/android/BUILD.gn View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chromecast/common/media/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/media/cdm/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/media/cma/backend/alsa/BUILD.gn View 1 4 chunks +0 lines, -5 lines 0 comments Download
M content/app/strings/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/devtools/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/android/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M content/shell/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M content/shell/android/BUILD.gn View 4 chunks +0 lines, -4 lines 0 comments Download
D content/shell/app/shell.exe.manifest View 1 chunk +0 lines, -20 lines 0 comments Download
M device/bluetooth/strings/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M device/media_transfer_protocol/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M device/serial/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M extensions/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/api/cast_channel/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/shell/common/api/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M extensions/strings/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/BUILD.gn View 3 chunks +0 lines, -31 lines 0 comments Download
M gpu/command_buffer/client/BUILD.gn View 2 chunks +1 line, -4 lines 0 comments Download
M gpu/gles2_conform_support/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/gles2_conform_support/egl/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/gles2_conform_support/native/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M gpu/tools/compositor_model_bench/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/BUILD.gn View 1 2 chunks +0 lines, -10 lines 0 comments Download
M jingle/BUILD.gn View 5 chunks +0 lines, -5 lines 0 comments Download
M printing/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M remoting/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M remoting/host/it2me/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M remoting/webapp/BUILD.gn View 3 chunks +0 lines, -4 lines 0 comments Download
M storage/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M storage/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M testing/android/appurify_support/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M testing/android/broker/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M testing/android/driver/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M testing/android/junit/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M testing/android/native_test/BUILD.gn View 4 chunks +0 lines, -4 lines 0 comments Download
M testing/android/reporter/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/build/scripts/scripts.gni View 1 2 chunks +1 line, -7 lines 0 comments Download
M third_party/isimpledom/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
brettw
More
4 years, 2 months ago (2016-09-27 19:44:14 UTC) #2
brettw
Fix
4 years, 2 months ago (2016-09-27 19:49:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373683003/40001
4 years, 2 months ago (2016-09-27 19:50:17 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-27 21:17:09 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 21:20:47 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cde1af7bd0ccf5b051bd3bac47290e15d8a0ef29
Cr-Commit-Position: refs/heads/master@{#421335}

Powered by Google App Engine
This is Rietveld 408576698