content/shell/BUILD.gn - Issue 2373683003: Remove som GYP annotations, remove unused manifest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/BUILD.gn

Issue 2373683003: Remove som GYP annotations, remove unused manifest. (Closed)

Patch Set: Fix Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/BUILD.gn

diff --git a/content/shell/BUILD.gn b/content/shell/BUILD.gn

index b7e5f79a7059a6055fb835f09e65966ea7b08a47..8a6a5a288111ee842d86301a5cf994a48d3e130c 100644

--- a/content/shell/BUILD.gn

+++ b/content/shell/BUILD.gn

@@ -485,8 +485,6 @@ if (is_android) {

info_plist_target = ":content_shell_plist"

}

} else {

- # TODO(brettw) when GYP is no longer necessary, delete

- # content/shell/app/shell.exe.manifest. This file is not used in GN.

executable("content_shell") {

testonly = true

@@ -532,7 +530,6 @@ if (is_android) {

}

if (is_win) {

- # GYP version: content/content_shell_and_tests.gyp:content_shell_crash_service

executable("content_shell_crash_service") {

sources = [

"tools/content_shell_crash_service.cc",

« no previous file with comments | « content/public/test/android/BUILD.gn ('k') | content/shell/android/BUILD.gn » ('j') | no next file with comments »