Add better consistency check and error output to plot script.

Add better consistency check and error output to plot script.

R=jkummerow@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=16537

[Jakob Kummerow, 2013-09-04 13:34:02]

https://codereview.chromium.org/23736004/diff/1/tools/plot-timer-events
File tools/plot-timer-events (right):

https://codereview.chromium.org/23736004/diff/1/tools/plot-timer-events#newco...
tools/plot-timer-events:79: rm -rf timer-events.plot
"rm -f" is enough.

https://codereview.chromium.org/23736004/diff/1/tools/profviz/composer.js
File tools/profviz/composer.js (left):

https://codereview.chromium.org/23736004/diff/1/tools/profviz/composer.js#old...
tools/profviz/composer.js:263: var processSharedLibrary = function(name, start,
end) {
Ain't it great to have compiler warnings for these things? ;-)

https://codereview.chromium.org/23736004/diff/1/tools/profviz/worker.js
File tools/profviz/worker.js (right):

https://codereview.chromium.org/23736004/diff/1/tools/profviz/worker.js#newco...
tools/profviz/worker.js:77: self.postMessage({"call": "reset", "args": text});
why does "reset" need the text as an arg?

https://codereview.chromium.org/23736004/diff/1/tools/profviz/worker.js#newco...
tools/profviz/worker.js:167: print: function() {
Y U NO pass in |text| anymore? Maybe you meant:

print: log_error,
printErr: log_error

[Yang, 2013-09-04 13:52:29]

addressed comments. please take another look.

https://codereview.chromium.org/23736004/diff/1/tools/plot-timer-events
File tools/plot-timer-events (right):

https://codereview.chromium.org/23736004/diff/1/tools/plot-timer-events#newco...
tools/plot-timer-events:79: rm -rf timer-events.plot
On 2013/09/04 13:34:03, Jakob wrote:
> "rm -f" is enough.

Done.

https://codereview.chromium.org/23736004/diff/1/tools/profviz/composer.js
File tools/profviz/composer.js (left):

https://codereview.chromium.org/23736004/diff/1/tools/profviz/composer.js#old...
tools/profviz/composer.js:263: var processSharedLibrary = function(name, start,
end) {
On 2013/09/04 13:34:03, Jakob wrote:
> Ain't it great to have compiler warnings for these things? ;-)

Yeah I never realized until now that the entire thing is duplicate.

https://codereview.chromium.org/23736004/diff/1/tools/profviz/worker.js
File tools/profviz/worker.js (right):

https://codereview.chromium.org/23736004/diff/1/tools/profviz/worker.js#newco...
tools/profviz/worker.js:77: self.postMessage({"call": "reset", "args": text});
On 2013/09/04 13:34:03, Jakob wrote:
> why does "reset" need the text as an arg?

you are right. done.

https://codereview.chromium.org/23736004/diff/1/tools/profviz/worker.js#newco...
tools/profviz/worker.js:167: print: function() {
On 2013/09/04 13:34:03, Jakob wrote:
> Y U NO pass in |text| anymore? Maybe you meant:
> 
> print: log_error,
> printErr: log_error

I meant to leave it as is. I messed with it, but realized that I don't want to
reset when the asm.js module reports errors.

[Jakob Kummerow, 2013-09-04 13:56:26]

lgtm

[Yang, 2013-09-04 15:19:32]

Committed patchset #2 manually as r16537 (presubmit successful).