tools/profviz/stdio.js - Issue 23736004: Add better consistency check and error output to plot script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/profviz/stdio.js

Issue 23736004: Add better consistency check and error output to plot script. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed comments Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/profviz/stdio.js

diff --git a/tools/profviz/stdio.js b/tools/profviz/stdio.js

index e8001494c9df641ffbb0cfce90f618ca729339f0..db38f042a7d016efb95e9d6803e8f59593920c83 100644

--- a/tools/profviz/stdio.js

+++ b/tools/profviz/stdio.js

@@ -44,7 +44,11 @@ if (!isNaN(range_end)) range_end_override = range_end;

var kResX = 1600;

var kResY = 600;

-var psc = new PlotScriptComposer(kResX, kResY);

+function log_error(text) {

+ print(text);

+ quit(1);

+var psc = new PlotScriptComposer(kResX, kResY, log_error);

psc.collectData(readline, distortion_per_entry);

psc.findPlotRange(range_start_override, range_end_override);

print("set terminal pngcairo size " + kResX + "," + kResY +

« no previous file with comments | « tools/profviz/profviz.js ('k') | tools/profviz/worker.js » ('j') | no next file with comments »