cocoa browser: bind cmd-opt-l, not cmd-l, for downloads

cocoa browser: bind cmd-opt-l, not cmd-l, for downloads

A longstanding trap in global_keyboard_shortcuts_mac: if a binding has a
character specified instead of a keycode, the option modifier in the command is
ignored, which makes sense, since option might be involved in typing the
character in the first place. However, it does mean that bindings should never
specify opt == true, which is exactly what I did in CL 2369453003. This CL adds
a DCHECK to ensure nobody else trips over this.

BUG=650528
Committed: https://crrev.com/c2af95142ec4aa2f5935921dd681c6351dff9fd6
Cr-Commit-Position: refs/heads/master@{#421203}

[Elly Fong-Jones, 2016-09-27 13:17:43]

Description was changed from

==========
cocoa browser: bind cmd-opt-l, not cmd-l, for downloads

A longstanding trap in global_keyboard_shortcuts_mac: if a binding has a
character specified instead of a keycode, the option modifier in the command is
ignored, which makes sense, since option might be involved in typing the
character in the first place. However, it does mean that bindings should never
specify opt == true, which is exactly what I did in CL 2369453003. This CL adds
a DCHECK to ensure nobody else trips over this.

BUG=650528
==========

to

==========
cocoa browser: bind cmd-opt-l, not cmd-l, for downloads

A longstanding trap in global_keyboard_shortcuts_mac: if a binding has a
character specified instead of a keycode, the option modifier in the command is
ignored, which makes sense, since option might be involved in typing the
character in the first place. However, it does mean that bindings should never
specify opt == true, which is exactly what I did in CL 2369453003. This CL adds
a DCHECK to ensure nobody else trips over this.

BUG=650528
==========

[Elly Fong-Jones, 2016-09-27 13:17:43]

ellyjones@chromium.org changed reviewers:
+ rsesek@chromium.org

[Elly Fong-Jones, 2016-09-27 13:17:53]

rsesek: ptal? :)

[Robert Sesek, 2016-09-27 13:41:56]

LGTM

[Elly Fong-Jones, 2016-09-27 13:44:25]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2016-09-27 13:44:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 14:37:18]

Description was changed from

==========
cocoa browser: bind cmd-opt-l, not cmd-l, for downloads

A longstanding trap in global_keyboard_shortcuts_mac: if a binding has a
character specified instead of a keycode, the option modifier in the command is
ignored, which makes sense, since option might be involved in typing the
character in the first place. However, it does mean that bindings should never
specify opt == true, which is exactly what I did in CL 2369453003. This CL adds
a DCHECK to ensure nobody else trips over this.

BUG=650528
==========

to

==========
cocoa browser: bind cmd-opt-l, not cmd-l, for downloads

A longstanding trap in global_keyboard_shortcuts_mac: if a binding has a
character specified instead of a keycode, the option modifier in the command is
ignored, which makes sense, since option might be involved in typing the
character in the first place. However, it does mean that bindings should never
specify opt == true, which is exactly what I did in CL 2369453003. This CL adds
a DCHECK to ensure nobody else trips over this.

BUG=650528
==========

[commit-bot: I haz the power, 2016-09-27 14:37:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-27 14:39:49]

Description was changed from

==========
cocoa browser: bind cmd-opt-l, not cmd-l, for downloads

A longstanding trap in global_keyboard_shortcuts_mac: if a binding has a
character specified instead of a keycode, the option modifier in the command is
ignored, which makes sense, since option might be involved in typing the
character in the first place. However, it does mean that bindings should never
specify opt == true, which is exactly what I did in CL 2369453003. This CL adds
a DCHECK to ensure nobody else trips over this.

BUG=650528
==========

to

==========
cocoa browser: bind cmd-opt-l, not cmd-l, for downloads

A longstanding trap in global_keyboard_shortcuts_mac: if a binding has a
character specified instead of a keycode, the option modifier in the command is
ignored, which makes sense, since option might be involved in typing the
character in the first place. However, it does mean that bindings should never
specify opt == true, which is exactly what I did in CL 2369453003. This CL adds
a DCHECK to ensure nobody else trips over this.

BUG=650528

Committed: https://crrev.com/c2af95142ec4aa2f5935921dd681c6351dff9fd6
Cr-Commit-Position: refs/heads/master@{#421203}
==========

[commit-bot: I haz the power, 2016-09-27 14:39:50]

Patchset 1 (id:??) landed as
https://crrev.com/c2af95142ec4aa2f5935921dd681c6351dff9fd6
Cr-Commit-Position: refs/heads/master@{#421203}