cocoa browser: bind cmd-opt-l, not cmd-l, for downloads

chrome/browser/global_keyboard_shortcuts_mac.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/global_keyboard_shortcuts_mac.h"
 
 #import <AppKit/AppKit.h>
 
 #include "base/logging.h"
 #include "base/macros.h"
@@ skipping 58 matching lines @@
       {true, false, false, false, kVK_ANSI_Keypad5, 0, IDC_SELECT_TAB_4},
       {true, false, false, false, kVK_ANSI_6, 0, IDC_SELECT_TAB_5},
       {true, false, false, false, kVK_ANSI_Keypad6, 0, IDC_SELECT_TAB_5},
       {true, false, false, false, kVK_ANSI_7, 0, IDC_SELECT_TAB_6},
       {true, false, false, false, kVK_ANSI_Keypad7, 0, IDC_SELECT_TAB_6},
       {true, false, false, false, kVK_ANSI_8, 0, IDC_SELECT_TAB_7},
       {true, false, false, false, kVK_ANSI_Keypad8, 0, IDC_SELECT_TAB_7},
       {true, false, false, false, kVK_ANSI_9, 0, IDC_SELECT_LAST_TAB},
       {true, false, false, false, kVK_ANSI_Keypad9, 0, IDC_SELECT_LAST_TAB},
       {true, true, false, false, kVK_ANSI_M, 0, IDC_SHOW_AVATAR_MENU},
-      {true, false, false, true, 0, 'l', IDC_SHOW_DOWNLOADS},
+      {true, false, false, true, kVK_ANSI_L, 0, IDC_SHOW_DOWNLOADS},
   };
 
   *num_entries = arraysize(keyboard_shortcuts);
 
   return keyboard_shortcuts;
 }
 
 const KeyboardShortcutData* GetDelayedWindowKeyboardShortcutTable(
     size_t* num_entries) {
   static const KeyboardShortcutData keyboard_shortcuts[] = {
@@ skipping 24 matching lines @@
   return keyboard_shortcuts;
 }
 
 static bool MatchesEventForKeyboardShortcut(
     const KeyboardShortcutData& shortcut,
     bool command_key, bool shift_key, bool cntrl_key, bool opt_key,
     int vkey_code, unichar key_char) {
   // Expects that one of |key_char| or |vkey_code| is 0.
   DCHECK((shortcut.key_char == 0) ^ (shortcut.vkey_code == 0));
   if (shortcut.key_char) {
+    // Shortcuts that have a |key_char| and have |opt_key| set are mistakes,
+    // since |opt_key| is not checked when there is a |key_char|.
+    DCHECK(!shortcut.opt_key);
     // The given shortcut key is to be matched by a keyboard character.
     // In this case we ignore shift and opt (alt) key modifiers, because
     // the character may be generated by a combination with those keys.
     if (shortcut.command_key == command_key &&
         shortcut.cntrl_key == cntrl_key &&
         shortcut.key_char == key_char)
       return true;
   } else if (shortcut.vkey_code) {
     // The given shortcut key is to be matched by a virtual key code.
     if (shortcut.command_key == command_key &&
@@ skipping 157 matching lines @@
       }
     }
 
     // opt/alt modifier is set (e.g. on german layout we want '{' for opt-8).
     if ([event modifierFlags] & NSAlternateKeyMask)
       return rawChar;
   }
 
   return noModifiersChar;
 }