Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2373503004: Revert of Add command buffer submits before copy calls in vulkan. (Closed)

Created:
4 years, 2 months ago by egdaniel
Modified:
4 years, 2 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add command buffer submits before copy calls in vulkan. (patchset #5 id:80001 of https://codereview.chromium.org/2363773006/ ) Reason for revert: breaking things since apparently nvidia != windows always... Original issue's description: > Add command buffer submits before copy calls in vulkan. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2363773006 > > Committed: https://skia.googlesource.com/skia/+/25661bac7722860b7589c5b01ec404531d941456 TBR=jvanverth@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/b353863db5a477a76e83af2c5c4492c8b800304a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M src/gpu/vk/GrVkCaps.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/vk/GrVkCaps.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/vk/GrVkCommandBuffer.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/gpu/vk/GrVkGpu.cpp View 3 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
egdaniel
Created Revert of Add command buffer submits before copy calls in vulkan.
4 years, 2 months ago (2016-09-27 17:14:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373503004/1
4 years, 2 months ago (2016-09-27 17:14:39 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 17:14:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b353863db5a477a76e83af2c5c4492c8b800304a

Powered by Google App Engine
This is Rietveld 408576698