Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleUnits.h

Issue 2373483003: Ensure valid VisiblePosition input for absoluteCaretBoundsOf (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleUnits.h
diff --git a/third_party/WebKit/Source/core/editing/VisibleUnits.h b/third_party/WebKit/Source/core/editing/VisibleUnits.h
index 881d86dab24cf56aa0e04fc3cf49fc46ef8acc87..bd53389224fedc6781d943f4c77bfe35473464bd 100644
--- a/third_party/WebKit/Source/core/editing/VisibleUnits.h
+++ b/third_party/WebKit/Source/core/editing/VisibleUnits.h
@@ -117,6 +117,11 @@ CORE_EXPORT PositionInFlatTree canonicalPositionOf(const PositionInFlatTree&);
CORE_EXPORT IntRect absoluteCaretBoundsOf(const VisiblePosition&);
CORE_EXPORT IntRect absoluteCaretBoundsOf(const VisiblePositionInFlatTree&);
+// This deprecated function accepts an invalid VisiblePosition as input, which
+// is discouraged. Callers should ensure passing a valid VisiblePosition to the
+// un-deprecated function listed above.
+CORE_EXPORT IntRect absoluteCaretBoundsOfDeprecated(const VisiblePosition&);
+
CORE_EXPORT UChar32 characterAfter(const VisiblePosition&);
CORE_EXPORT UChar32 characterAfter(const VisiblePositionInFlatTree&);
CORE_EXPORT UChar32 characterBefore(const VisiblePosition&);

Powered by Google App Engine
This is Rietveld 408576698