Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Side by Side Diff: third_party/WebKit/Source/core/editing/VisibleUnits.h

Issue 2373483003: Ensure valid VisiblePosition input for absoluteCaretBoundsOf (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 // If true, adjacent candidates are visually distinct. 110 // If true, adjacent candidates are visually distinct.
111 CORE_EXPORT bool endsOfNodeAreVisuallyDistinctPositions(const Node*); 111 CORE_EXPORT bool endsOfNodeAreVisuallyDistinctPositions(const Node*);
112 112
113 CORE_EXPORT Position canonicalPositionOf(const Position&); 113 CORE_EXPORT Position canonicalPositionOf(const Position&);
114 CORE_EXPORT PositionInFlatTree canonicalPositionOf(const PositionInFlatTree&); 114 CORE_EXPORT PositionInFlatTree canonicalPositionOf(const PositionInFlatTree&);
115 115
116 // Bounds of (possibly transformed) caret in absolute coords 116 // Bounds of (possibly transformed) caret in absolute coords
117 CORE_EXPORT IntRect absoluteCaretBoundsOf(const VisiblePosition&); 117 CORE_EXPORT IntRect absoluteCaretBoundsOf(const VisiblePosition&);
118 CORE_EXPORT IntRect absoluteCaretBoundsOf(const VisiblePositionInFlatTree&); 118 CORE_EXPORT IntRect absoluteCaretBoundsOf(const VisiblePositionInFlatTree&);
119 119
120 // This deprecated function accepts an invalid VisiblePosition as input, which
121 // is discouraged. Callers should ensure passing a valid VisiblePosition to the
122 // un-deprecated function listed above.
123 CORE_EXPORT IntRect absoluteCaretBoundsOfDeprecated(const VisiblePosition&);
124
120 CORE_EXPORT UChar32 characterAfter(const VisiblePosition&); 125 CORE_EXPORT UChar32 characterAfter(const VisiblePosition&);
121 CORE_EXPORT UChar32 characterAfter(const VisiblePositionInFlatTree&); 126 CORE_EXPORT UChar32 characterAfter(const VisiblePositionInFlatTree&);
122 CORE_EXPORT UChar32 characterBefore(const VisiblePosition&); 127 CORE_EXPORT UChar32 characterBefore(const VisiblePosition&);
123 CORE_EXPORT UChar32 characterBefore(const VisiblePositionInFlatTree&); 128 CORE_EXPORT UChar32 characterBefore(const VisiblePositionInFlatTree&);
124 129
125 // TODO(yosin) Since return value of |leftPositionOf()| with |VisiblePosition| 130 // TODO(yosin) Since return value of |leftPositionOf()| with |VisiblePosition|
126 // isn't defined well on flat tree, we should not use it for a position in 131 // isn't defined well on flat tree, we should not use it for a position in
127 // flat tree. 132 // flat tree.
128 CORE_EXPORT VisiblePosition leftPositionOf(const VisiblePosition&); 133 CORE_EXPORT VisiblePosition leftPositionOf(const VisiblePosition&);
129 CORE_EXPORT VisiblePositionInFlatTree leftPositionOf(const VisiblePositionInFlat Tree&); 134 CORE_EXPORT VisiblePositionInFlatTree leftPositionOf(const VisiblePositionInFlat Tree&);
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
258 263
259 // Returns a hit-tested VisiblePosition for the given point in contents-space 264 // Returns a hit-tested VisiblePosition for the given point in contents-space
260 // coordinates. 265 // coordinates.
261 CORE_EXPORT VisiblePosition visiblePositionForContentsPoint(const IntPoint&, Loc alFrame*); 266 CORE_EXPORT VisiblePosition visiblePositionForContentsPoint(const IntPoint&, Loc alFrame*);
262 267
263 CORE_EXPORT bool rendersInDifferentPosition(const Position&, const Position&); 268 CORE_EXPORT bool rendersInDifferentPosition(const Position&, const Position&);
264 269
265 } // namespace blink 270 } // namespace blink
266 271
267 #endif // VisibleUnits_h 272 #endif // VisibleUnits_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698