Ensure valid VisiblePosition input for absoluteCaretBoundsOf

Ensure valid VisiblePosition input for absoluteCaretBoundsOf

BUG=648949
Committed: https://crrev.com/c7fdeab7c9ee00f1ea57b71ee5341109280b778e
Cr-Commit-Position: refs/heads/master@{#421418}

[Xiaocheng, 2016-09-27 08:50:32]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 08:50:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-09-27 09:16:58]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-09-27 09:16:59]

PTAL.

[yosin_UTC9, 2016-09-27 10:09:50]

https://codereview.chromium.org/2373483003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/VisibleUnits.cpp (right):

https://codereview.chromium.org/2373483003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/VisibleUnits.cpp:2959: static IntRect
absoluteCaretBoundsOfAlgorithmDeprecated(const
VisiblePositionTemplate<Strategy>& visiblePosition)
Let's make absoluteCaretBoundsOfAlgorithm to take PositionWithAffinity to avoid
copy & paste.


IntRect absoluteCaretBoundsOf(const VisiblePosition& visiblePosition)
{
  DCHECK(visiblePosition.isValid()) << visiblePositon;
  return
absoluteCaretBoundsOfAlgorithm<EditingStrategy>(visiblePosition.toPositionWithAffinity());
}

IntRect absoluteCaretBoundsOfDeprecated(const VisiblePosition& visiblePosition)
{
  return
absoluteCaretBoundsOfAlgorithm<EditingStrategy>(visiblePosition.toPositionWithAffinity());
}


When we have VP::toPositionWithAffiniktyDeprecated(), we could write:

IntRect absoluteCaretBoundsOf(const VisiblePosition& visiblePosition)
{
  return
absoluteCaretBoundsOfAlgorithm<EditingStrategy>(visiblePosition.toPositionWithAffinity());
}

IntRect absoluteCaretBoundsOfDeprecated(const VisiblePosition& visiblePosition)
{
  return
absoluteCaretBoundsOfAlgorithm<EditingStrategy>(visiblePosition.toPositionWithAffinityDeprecated());
}

[commit-bot: I haz the power, 2016-09-27 10:10:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 10:10:22]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-09-27 11:53:58]

Description was changed from

==========
Mark absoluteCaretBoundsOf in VisibleUnits deprecated

BUG=648949
==========

to

==========
Ensure valid VisiblePosition input for absoluteCaretBoundsOf

BUG=648949
==========

[Xiaocheng, 2016-09-27 12:03:21]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 12:03:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-09-27 12:05:08]

I just realized that it's fairly easy to ensure valid VP for this function. So
it's done and there's no need to introduced deprecated versions.

For those functions in VisibleUnits unnecessarily taking VP as parameters, maybe
we can sweep them in the future in some unified manner.

[commit-bot: I haz the power, 2016-09-27 13:40:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 13:40:19]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-09-28 01:24:05]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-09-28 01:24:06]

lgtm

https://codereview.chromium.org/2373483003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp
(right):

https://codereview.chromium.org/2373483003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp:666:
startOfParagraphToMove = createVisiblePosition(storedStartOfParagraphToMove);
Rational of converting VP:
|startOfParagraphToMove| is used as an argument of |absoluteCaretBoundsOf()| at
L692.

[commit-bot: I haz the power, 2016-09-28 01:24:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 01:30:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-28 01:33:24]

Description was changed from

==========
Ensure valid VisiblePosition input for absoluteCaretBoundsOf

BUG=648949
==========

to

==========
Ensure valid VisiblePosition input for absoluteCaretBoundsOf

BUG=648949

Committed: https://crrev.com/c7fdeab7c9ee00f1ea57b71ee5341109280b778e
Cr-Commit-Position: refs/heads/master@{#421418}
==========

[commit-bot: I haz the power, 2016-09-28 01:33:25]

Patchset 2 (id:??) landed as
https://crrev.com/c7fdeab7c9ee00f1ea57b71ee5341109280b778e
Cr-Commit-Position: refs/heads/master@{#421418}