third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp - Issue 2373483003: Ensure valid VisiblePosition input for absoluteCaretBoundsOf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

Issue 2373483003: Ensure valid VisiblePosition input for absoluteCaretBoundsOf (Closed)

Patch Set: Ensure valid VP for absoluteCaretBoundsOf Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp b/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

index c2614e5db7ac9ee1518d313168510d24652391d6..9ca3595bcabd1aee25f14fe4519671ed7ab4e283 100644

--- a/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

@@ -658,10 +658,12 @@ void DeleteSelectionCommand::mergeParagraphs(EditingState* editingState)

// We need to merge into m_upstreamStart's block, but it's been emptied out and collapsed by deletion.

if (!mergeDestination.deepEquivalent().anchorNode() || (!mergeDestination.deepEquivalent().anchorNode()->isDescendantOf(enclosingBlock(m_upstreamStart.computeContainerNode())) && (!mergeDestination.deepEquivalent().anchorNode()->hasChildren() || !m_upstreamStart.computeContainerNode()->hasChildren())) || (m_startsAtEmptyLine && mergeDestination.deepEquivalent() != startOfParagraphToMove.deepEquivalent())) {

+ PositionWithAffinity storedStartOfParagraphToMove = startOfParagraphToMove.toPositionWithAffinity();

insertNodeAt(HTMLBRElement::create(document()), m_upstreamStart, editingState);

if (editingState->isAborted())

return;

mergeDestination = createVisiblePositionDeprecated(m_upstreamStart);

+ startOfParagraphToMove = createVisiblePosition(storedStartOfParagraphToMove);

yosin_UTC9 2016/09/28 01:24:06 Rational of converting VP: |startOfParagraphToMove

}

if (mergeDestination.deepEquivalent() == startOfParagraphToMove.deepEquivalent())

« no previous file with comments | « third_party/WebKit/Source/core/editing/VisibleUnits.cpp ('k') | no next file » | no next file with comments »