Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2373113003:
DevTools: ConsoleViewMessage isolate _formatMessageAsTable() and single dataGrid (Closed)
|
Created:
4 years, 2 months ago by luoe Modified:
4 years, 2 months ago Reviewers:
lushnikov CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: ConsoleViewMessage isolate _formatMessageAsTable() and single dataGrid
This CL separates table formatting logic from the rest. Tables may produce only
a single SortableDataGrid that is stored on the ConsoleViewMessage.
Committed: https://crrev.com/04568b704931d302180611a8734d77713740ea04
Cr-Commit-Position: refs/heads/master@{#422997}
Patch Set 1 #
Total comments: 4
Patch Set 2 : rebase #Patch Set 3 : ac-2, datagrid typo #
Total comments: 2
Patch Set 4 : rebase with set 8 #Patch Set 5 : rename buildMessageTable #Patch Set 6 : rebase with set 10 #Messages
Total messages: 26 (17 generated)
Description was changed from ========== DevTools: isolate table formatting logic ========== to ========== DevTools: ConsoleViewMessage isolate _formatMessageAsTable() and _dataGrids > _dataGrid This CL separates table formatting logic from the rest. Tables may produce only a single SortableDataGrid that is stored on the ConsoleViewMessage. ==========
Description was changed from ========== DevTools: ConsoleViewMessage isolate _formatMessageAsTable() and _dataGrids > _dataGrid This CL separates table formatting logic from the rest. Tables may produce only a single SortableDataGrid that is stored on the ConsoleViewMessage. ========== to ========== DevTools: ConsoleViewMessage isolate _formatMessageAsTable() and single dataGrid This CL separates table formatting logic from the rest. Tables may produce only a single SortableDataGrid that is stored on the ConsoleViewMessage. ==========
luoe@chromium.org changed reviewers: + lushnikov@chromium.org
https://codereview.chromium.org/2373113003/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js (left): https://codereview.chromium.org/2373113003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:47: this._dataGrids = []; whoa, nice! https://codereview.chromium.org/2373113003/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js (right): https://codereview.chromium.org/2373113003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:615: _buildTableDataGrid: function(table) maybe join this with _formatMessageAsTable?
Additional changes: - Fixed typo "_datagrid" >> "_dataGrid" PTAL https://codereview.chromium.org/2373113003/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js (left): https://codereview.chromium.org/2373113003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:47: this._dataGrids = []; On 2016/09/28 20:52:35, lushnikov wrote: > whoa, nice! Done.
https://codereview.chromium.org/2373113003/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js (right): https://codereview.chromium.org/2373113003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:615: _buildTableDataGrid: function(table) On 2016/09/28 20:52:35, lushnikov wrote: > maybe join this with _formatMessageAsTable? Done.
lgtm please, make sure this doesn't break table fomratting https://codereview.chromium.org/2373113003/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js (right): https://codereview.chromium.org/2373113003/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:144: _formatMessageAsTable: function(consoleMessage) _buildTableMessage:
The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by luoe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2373113003/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js (right): https://codereview.chromium.org/2373113003/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:144: _formatMessageAsTable: function(consoleMessage) On 2016/09/30 21:30:47, lushnikov wrote: > _buildTableMessage: Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by luoe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by luoe@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lushnikov@chromium.org Link to the patchset: https://codereview.chromium.org/2373113003/#ps100001 (title: "rebase with set 10")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== DevTools: ConsoleViewMessage isolate _formatMessageAsTable() and single dataGrid This CL separates table formatting logic from the rest. Tables may produce only a single SortableDataGrid that is stored on the ConsoleViewMessage. ========== to ========== DevTools: ConsoleViewMessage isolate _formatMessageAsTable() and single dataGrid This CL separates table formatting logic from the rest. Tables may produce only a single SortableDataGrid that is stored on the ConsoleViewMessage. ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== DevTools: ConsoleViewMessage isolate _formatMessageAsTable() and single dataGrid This CL separates table formatting logic from the rest. Tables may produce only a single SortableDataGrid that is stored on the ConsoleViewMessage. ========== to ========== DevTools: ConsoleViewMessage isolate _formatMessageAsTable() and single dataGrid This CL separates table formatting logic from the rest. Tables may produce only a single SortableDataGrid that is stored on the ConsoleViewMessage. Committed: https://crrev.com/04568b704931d302180611a8734d77713740ea04 Cr-Commit-Position: refs/heads/master@{#422997} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/04568b704931d302180611a8734d77713740ea04 Cr-Commit-Position: refs/heads/master@{#422997} |
