Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issue 2372973003: Fix too strict debug assertion in disassembler. (Closed)

Created:
4 years, 2 months ago by Florian Schneider
Modified:
4 years, 2 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix too strict debug assertion in disassembler. When printing function objects to JSON, we still allocate temporary strings on the Dart heap. BUG= Committed: https://github.com/dart-lang/sdk/commit/add88f4ee3914d3510ba401a2514fd2728fe0db6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M runtime/vm/disassembler.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
Temporary fix. I'll look into refactoring QualifiedName() to only use zone-memory instead of allocating on ...
4 years, 2 months ago (2016-09-27 21:14:02 UTC) #2
Florian Schneider
Committed patchset #1 (id:1) manually as add88f4ee3914d3510ba401a2514fd2728fe0db6 (presubmit successful).
4 years, 2 months ago (2016-09-27 21:19:41 UTC) #4
siva
4 years, 2 months ago (2016-09-27 22:35:50 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698