Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Unified Diff: runtime/vm/disassembler.cc

Issue 2372973003: Fix too strict debug assertion in disassembler. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/disassembler.cc
diff --git a/runtime/vm/disassembler.cc b/runtime/vm/disassembler.cc
index dbd7eaa3cca0d7b945f3f4a5e72f2be53df49645..1b625401509ae9954876a10939592509d7c75ffa 100644
--- a/runtime/vm/disassembler.cc
+++ b/runtime/vm/disassembler.cc
@@ -105,7 +105,6 @@ void Disassembler::Disassemble(uword start,
uword end,
DisassemblyFormatter* formatter,
const Code& code) {
- NoSafepointScope no_safepoint;
const Code::Comments& comments =
code.IsNull() ? Code::Comments::New(0) : code.comments();
ASSERT(formatter != NULL);
@@ -168,11 +167,8 @@ void Disassembler::DisassembleCodeHelper(
const char* function_fullname, const Code& code, bool optimized) {
LocalVarDescriptors& var_descriptors = LocalVarDescriptors::Handle();
if (FLAG_print_variable_descriptors) {
- // This flag is not on by default, and for debugging purposes only.
- // Since this may allocate, do it outside the NoSafepointScope.
var_descriptors = code.GetLocalVarDescriptors();
}
- NoSafepointScope no_safepoint;
THR_Print("Code for %sfunction '%s' {\n",
optimized ? "optimized " : "",
function_fullname);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698