Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2372923002: Move Monochrome locale .pak files upstream (Closed)

Created:
4 years, 2 months ago by agrieve
Modified:
4 years, 2 months ago
Reviewers:
michaelbai
CC:
chromium-reviews, estevenson
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move Monochrome locale_pak_resources target upstream This includes a "monochrome_public_apk_tmpl" so that the downstream reference to locale_pak_resources can be removed. BUG=641032, 650927 Committed: https://crrev.com/8f59a30117fb0a3ac62aa653a5c3d79249939bfe Cr-Commit-Position: refs/heads/master@{#421617}

Patch Set 1 #

Patch Set 2 : add in monochrome template #

Patch Set 3 : remove unused target: monochrome_assets #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -7 lines) Patch
M chrome/android/BUILD.gn View 1 2 2 chunks +15 lines, -7 lines 2 comments Download
M chrome/android/chrome_public_apk_tmpl.gni View 1 1 chunk +43 lines, -0 lines 0 comments Download
M chrome/android/monochrome_repack_locales.gni View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_paks.gni View 2 chunks +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (8 generated)
agrieve
michaelbai@ - please review. brettw@ - for //chrome OWNERS
4 years, 2 months ago (2016-09-27 01:31:11 UTC) #2
michaelbai
could you send me corresponding downstream patch? https://codereview.chromium.org/2372923002/diff/40001/chrome/android/BUILD.gn File chrome/android/BUILD.gn (left): https://codereview.chromium.org/2372923002/diff/40001/chrome/android/BUILD.gn#oldcode562 chrome/android/BUILD.gn:562: "//android_webview:monochrome_webview_assets", Where ...
4 years, 2 months ago (2016-09-28 00:35:30 UTC) #5
agrieve
emailed you directly with the list & order of patches to make this all work ...
4 years, 2 months ago (2016-09-28 00:46:58 UTC) #6
michaelbai
lgtm
4 years, 2 months ago (2016-09-28 19:02:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372923002/40001
4 years, 2 months ago (2016-09-28 19:14:07 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-28 20:00:27 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 20:01:51 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8f59a30117fb0a3ac62aa653a5c3d79249939bfe
Cr-Commit-Position: refs/heads/master@{#421617}

Powered by Google App Engine
This is Rietveld 408576698