Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3658)

Unified Diff: chrome/android/BUILD.gn

Issue 2372923002: Move Monochrome locale .pak files upstream (Closed)
Patch Set: remove unused target: monochrome_assets Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/chrome_public_apk_tmpl.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/BUILD.gn
diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
index 7334f582d17534643a7affad24c60f3216e5743e..22bc59b395b5f83c9b586049dff5a26bc402ca23 100644
--- a/chrome/android/BUILD.gn
+++ b/chrome/android/BUILD.gn
@@ -2,6 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import("//android_webview/webview_repack_locales_list.gni")
import("//build/config/android/config.gni")
import("//build/config/android/rules.gni")
import("//build/util/process_version.gni")
@@ -549,19 +550,26 @@ if (current_toolchain == default_toolchain) {
"//android_webview:generate_aw_resources",
]
+ additional_locale_source_patterns = webview_repack_locales_source_patterns
+ deps += webview_repack_locales_deps
+
if (enable_resource_whitelist_generation) {
repack_whitelist = monochrome_resource_whitelist
deps += [ ":monochrome_resource_whitelist" ]
}
}
-} # current_toolchain == host_toolchain
-java_group("monochrome_assets") {
- deps = [
- ":monochrome_pak_assets",
- "//android_webview:monochrome_webview_assets",
michaelbai 2016/09/28 00:35:29 Where those assets defined in android_webview:mono
agrieve 2016/09/28 00:46:58 They are referenced directly downstream.
- ]
-}
+ locale_pak_resources("monochrome_locale_paks") {
+ sources = []
+ foreach(_locale, locales) {
+ sources += [ "$target_gen_dir/monochrome_paks/locales/$_locale.pak" ]
+ }
+
+ deps = [
+ ":monochrome_paks",
+ ]
+ }
+} # current_toolchain == host_toolchain
android_assets("monochrome_pak_assets") {
sources = [
« no previous file with comments | « no previous file | chrome/android/chrome_public_apk_tmpl.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698