Ensure valid VisiblePosition input for inSameBlock

Ensure valid VisiblePosition input for inSameBlock

This patch postpones the creation of |visiblePos| in
|InsertParagraphSeparatorCommand::doApply|  so that |visiblePos|
does not get invalidated by the creation of |blockToInsert|.

Note: ideally, the creation and modification of an out-of-document
element (in this case, |blockToInsert|) shouldn't invalidate
VisiblePositions, but this is still hard to fix in the current
implementation. See crbug.com/650164.

BUG=648949
Committed: https://crrev.com/172391bd511c3871ff8c7bcd73fa9cb5c1d12043
Cr-Commit-Position: refs/heads/master@{#421138}

[Xiaocheng, 2016-09-27 02:44:22]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 02:44:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 05:51:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 05:51:51]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-09-27 05:54:12]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-09-27 05:54:13]

PTAL.

[yosin_UTC9, 2016-09-27 07:27:17]

lgtm


Please put a reason why you shuffle variable initialization, e.g.
cloneElementWithoutChildren() increments DOM tree version.

[Xiaocheng, 2016-09-27 07:32:43]

Description was changed from

==========
Ensure valid VisiblePosition input for inSameBlock

BUG=648949
==========

to

==========
Ensure valid VisiblePosition input for inSameBlock

This patch postpones the creation of |visiblePos| in
|InsertParagraphSeparatorCommand::doApply|  so that |visiblePos|
does not get invalidated by the creation of |blockToInsert|.

Note: ideally, the creation and modification of an out-of-document
element (in this case, |blockToInsert|) shouldn't invalidate
VisiblePositions, but this is still hard to fix in the current
implementation. See crbug.com/650164.

BUG=648949
==========

[Xiaocheng, 2016-09-27 07:33:12]

On 2016/09/27 at 07:27:17, yosin wrote:
> lgtm
> 
> 
> Please put a reason why you shuffle variable initialization, e.g.
cloneElementWithoutChildren() increments DOM tree version.

Done. Thanks.

[Xiaocheng, 2016-09-27 07:33:14]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2016-09-27 07:33:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 07:38:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-27 07:39:42]

Description was changed from

==========
Ensure valid VisiblePosition input for inSameBlock

This patch postpones the creation of |visiblePos| in
|InsertParagraphSeparatorCommand::doApply|  so that |visiblePos|
does not get invalidated by the creation of |blockToInsert|.

Note: ideally, the creation and modification of an out-of-document
element (in this case, |blockToInsert|) shouldn't invalidate
VisiblePositions, but this is still hard to fix in the current
implementation. See crbug.com/650164.

BUG=648949
==========

to

==========
Ensure valid VisiblePosition input for inSameBlock

This patch postpones the creation of |visiblePos| in
|InsertParagraphSeparatorCommand::doApply|  so that |visiblePos|
does not get invalidated by the creation of |blockToInsert|.

Note: ideally, the creation and modification of an out-of-document
element (in this case, |blockToInsert|) shouldn't invalidate
VisiblePositions, but this is still hard to fix in the current
implementation. See crbug.com/650164.

BUG=648949

Committed: https://crrev.com/172391bd511c3871ff8c7bcd73fa9cb5c1d12043
Cr-Commit-Position: refs/heads/master@{#421138}
==========

[commit-bot: I haz the power, 2016-09-27 07:39:43]

Patchset 1 (id:??) landed as
https://crrev.com/172391bd511c3871ff8c7bcd73fa9cb5c1d12043
Cr-Commit-Position: refs/heads/master@{#421138}