Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 23729006: thread isolate for files starting with 'b' and 'c' (Closed)

Created:
7 years, 3 months ago by dcarney
Modified:
7 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

thread isolate for files starting with 'b' and 'c' R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16489

Patch Set 1 #

Total comments: 4

Patch Set 2 : remaining arches #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -101 lines) Patch
M src/arm/codegen-arm.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm/full-codegen-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/builtins.h View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/code-stubs.h View 1 23 chunks +23 lines, -23 lines 0 comments Download
M src/code-stubs.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 23 chunks +48 lines, -45 lines 0 comments Download
M src/codegen.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/contexts.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/contexts.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/counters.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/counters.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/codegen-ia32.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/v8-counters.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M src/x64/codegen-x64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
dcarney
7 years, 3 months ago (2013-09-02 11:17:20 UTC) #1
Sven Panne
https://codereview.chromium.org/23729006/diff/1/src/code-stubs.cc File src/code-stubs.cc (right): https://codereview.chromium.org/23729006/diff/1/src/code-stubs.cc#newcode49 src/code-stubs.cc:49: miss_handler_(), Is this change intentional? I can't easily see ...
7 years, 3 months ago (2013-09-02 12:40:51 UTC) #2
dcarney
https://codereview.chromium.org/23729006/diff/1/src/code-stubs.cc File src/code-stubs.cc (right): https://codereview.chromium.org/23729006/diff/1/src/code-stubs.cc#newcode49 src/code-stubs.cc:49: miss_handler_(), On 2013/09/02 12:40:52, Sven Panne wrote: > Is ...
7 years, 3 months ago (2013-09-02 12:47:00 UTC) #3
Sven Panne
lgtm
7 years, 3 months ago (2013-09-02 14:25:31 UTC) #4
dcarney
7 years, 3 months ago (2013-09-03 06:57:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r16489 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698