Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1940)

Unified Diff: media/renderers/renderer_impl.cc

Issue 2372863002: Rename VideoRenderer::OnTimeStateChanged to OnTime{Progressing,Stopped} (Closed)
Patch Set: suggestion Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/video_renderer.h ('k') | media/renderers/renderer_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/renderers/renderer_impl.cc
diff --git a/media/renderers/renderer_impl.cc b/media/renderers/renderer_impl.cc
index c4fbf53d3ffa3d1badacd0621677c3aaab570ade..b0871713281e03ccb0ae408cf67c83c0e51821ec 100644
--- a/media/renderers/renderer_impl.cc
+++ b/media/renderers/renderer_impl.cc
@@ -291,9 +291,9 @@ void RendererImpl::SetPlaybackRate(double playback_rate) {
return;
if (old_rate == 0 && playback_rate > 0)
- video_renderer_->OnTimeStateChanged(true);
+ video_renderer_->OnTimeProgressing();
else if (old_rate > 0 && playback_rate == 0)
- video_renderer_->OnTimeStateChanged(false);
+ video_renderer_->OnTimeStopped();
}
void RendererImpl::SetVolume(float volume) {
@@ -595,7 +595,7 @@ bool RendererImpl::HandleRestartedStreamBufferingChanges(
deferred_video_underflow_cb_.Cancel();
video_buffering_state_ = new_buffering_state;
if (playback_rate_ > 0)
- video_renderer_->OnTimeStateChanged(true);
+ video_renderer_->OnTimeProgressing();
return true;
}
}
@@ -752,7 +752,7 @@ void RendererImpl::PausePlayback() {
time_source_->StopTicking();
}
if (playback_rate_ > 0 && video_renderer_)
- video_renderer_->OnTimeStateChanged(false);
+ video_renderer_->OnTimeStopped();
}
void RendererImpl::StartPlayback() {
@@ -765,7 +765,7 @@ void RendererImpl::StartPlayback() {
time_ticking_ = true;
time_source_->StartTicking();
if (playback_rate_ > 0 && video_renderer_)
- video_renderer_->OnTimeStateChanged(true);
+ video_renderer_->OnTimeProgressing();
}
void RendererImpl::OnRendererEnded(DemuxerStream::Type type) {
@@ -783,7 +783,7 @@ void RendererImpl::OnRendererEnded(DemuxerStream::Type type) {
DCHECK(!video_ended_);
video_ended_ = true;
DCHECK(video_renderer_);
- video_renderer_->OnTimeStateChanged(false);
+ video_renderer_->OnTimeStopped();
}
RunEndedCallbackIfNeeded();
« no previous file with comments | « media/base/video_renderer.h ('k') | media/renderers/renderer_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698