Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: media/renderers/renderer_impl_unittest.cc

Issue 2372863002: Rename VideoRenderer::OnTimeStateChanged to OnTime{Progressing,Stopped} (Closed)
Patch Set: suggestion Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/renderers/renderer_impl.cc ('k') | media/renderers/video_renderer_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/renderers/renderer_impl_unittest.cc
diff --git a/media/renderers/renderer_impl_unittest.cc b/media/renderers/renderer_impl_unittest.cc
index 489503044c525345ab4378908bfa2943758c2e0f..1e3e70696a280bd0f42e259df4280908736aafbc 100644
--- a/media/renderers/renderer_impl_unittest.cc
+++ b/media/renderers/renderer_impl_unittest.cc
@@ -427,7 +427,7 @@ TEST_F(RendererImplTest, StartPlayingFromWithPlaybackRate) {
Mock::VerifyAndClearExpectations(video_renderer_);
// Positive playback rate when ticking should start time.
- EXPECT_CALL(*video_renderer_, OnTimeStateChanged(true));
+ EXPECT_CALL(*video_renderer_, OnTimeProgressing());
SetPlaybackRate(1.0);
Mock::VerifyAndClearExpectations(video_renderer_);
@@ -436,7 +436,7 @@ TEST_F(RendererImplTest, StartPlayingFromWithPlaybackRate) {
Mock::VerifyAndClearExpectations(video_renderer_);
// Zero playback rate should stop time.
- EXPECT_CALL(*video_renderer_, OnTimeStateChanged(false));
+ EXPECT_CALL(*video_renderer_, OnTimeStopped());
SetPlaybackRate(0.0);
Mock::VerifyAndClearExpectations(video_renderer_);
@@ -445,8 +445,8 @@ TEST_F(RendererImplTest, StartPlayingFromWithPlaybackRate) {
Mock::VerifyAndClearExpectations(video_renderer_);
// Starting playback and flushing should cause time to stop.
- EXPECT_CALL(*video_renderer_, OnTimeStateChanged(true));
- EXPECT_CALL(*video_renderer_, OnTimeStateChanged(false));
+ EXPECT_CALL(*video_renderer_, OnTimeProgressing());
+ EXPECT_CALL(*video_renderer_, OnTimeStopped());
SetPlaybackRate(1.0);
Flush(false);
@@ -507,7 +507,7 @@ TEST_F(RendererImplTest, VideoStreamEnded) {
EXPECT_CALL(time_source_, StopTicking());
EXPECT_CALL(callbacks_, OnEnded());
- EXPECT_CALL(*video_renderer_, OnTimeStateChanged(false));
+ EXPECT_CALL(*video_renderer_, OnTimeStopped());
video_renderer_client_->OnEnded();
base::RunLoop().RunUntilIdle();
@@ -523,7 +523,7 @@ TEST_F(RendererImplTest, AudioVideoStreamsEnded) {
EXPECT_CALL(time_source_, StopTicking());
EXPECT_CALL(callbacks_, OnEnded());
- EXPECT_CALL(*video_renderer_, OnTimeStateChanged(false));
+ EXPECT_CALL(*video_renderer_, OnTimeStopped());
video_renderer_client_->OnEnded();
base::RunLoop().RunUntilIdle();
« no previous file with comments | « media/renderers/renderer_impl.cc ('k') | media/renderers/video_renderer_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698