Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Unified Diff: media/renderers/renderer_impl_unittest.cc

Issue 2372863002: Rename VideoRenderer::OnTimeStateChanged to OnTime{Progressing,Stopped} (Closed)
Patch Set: fix some comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/renderers/renderer_impl_unittest.cc
diff --git a/media/renderers/renderer_impl_unittest.cc b/media/renderers/renderer_impl_unittest.cc
index 489503044c525345ab4378908bfa2943758c2e0f..11c0c7fe1af06e75181ab80db2986cdc81ab5586 100644
--- a/media/renderers/renderer_impl_unittest.cc
+++ b/media/renderers/renderer_impl_unittest.cc
@@ -427,7 +427,7 @@ TEST_F(RendererImplTest, StartPlayingFromWithPlaybackRate) {
Mock::VerifyAndClearExpectations(video_renderer_);
// Positive playback rate when ticking should start time.
- EXPECT_CALL(*video_renderer_, OnTimeStateChanged(true));
+ EXPECT_CALL(*video_renderer_, TimeStartedProgressing());
SetPlaybackRate(1.0);
Mock::VerifyAndClearExpectations(video_renderer_);
@@ -436,7 +436,7 @@ TEST_F(RendererImplTest, StartPlayingFromWithPlaybackRate) {
Mock::VerifyAndClearExpectations(video_renderer_);
// Zero playback rate should stop time.
- EXPECT_CALL(*video_renderer_, OnTimeStateChanged(false));
+ EXPECT_CALL(*video_renderer_, TimeStoppedProgressing());
SetPlaybackRate(0.0);
Mock::VerifyAndClearExpectations(video_renderer_);
@@ -445,8 +445,8 @@ TEST_F(RendererImplTest, StartPlayingFromWithPlaybackRate) {
Mock::VerifyAndClearExpectations(video_renderer_);
// Starting playback and flushing should cause time to stop.
- EXPECT_CALL(*video_renderer_, OnTimeStateChanged(true));
- EXPECT_CALL(*video_renderer_, OnTimeStateChanged(false));
+ EXPECT_CALL(*video_renderer_, TimeStartedProgressing());
+ EXPECT_CALL(*video_renderer_, TimeStoppedProgressing());
SetPlaybackRate(1.0);
Flush(false);
@@ -507,7 +507,7 @@ TEST_F(RendererImplTest, VideoStreamEnded) {
EXPECT_CALL(time_source_, StopTicking());
EXPECT_CALL(callbacks_, OnEnded());
- EXPECT_CALL(*video_renderer_, OnTimeStateChanged(false));
+ EXPECT_CALL(*video_renderer_, TimeStoppedProgressing());
video_renderer_client_->OnEnded();
base::RunLoop().RunUntilIdle();
@@ -523,7 +523,7 @@ TEST_F(RendererImplTest, AudioVideoStreamsEnded) {
EXPECT_CALL(time_source_, StopTicking());
EXPECT_CALL(callbacks_, OnEnded());
- EXPECT_CALL(*video_renderer_, OnTimeStateChanged(false));
+ EXPECT_CALL(*video_renderer_, TimeStoppedProgressing());
video_renderer_client_->OnEnded();
base::RunLoop().RunUntilIdle();

Powered by Google App Engine
This is Rietveld 408576698