media/renderers/video_renderer_impl.h - Issue 2372863002: Rename VideoRenderer::OnTimeStateChanged to OnTime{Progressing,Stopped}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/renderers/video_renderer_impl.h

Issue 2372863002: Rename VideoRenderer::OnTimeStateChanged to OnTime{Progressing,Stopped} (Closed)

Patch Set: fix some comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/renderers/video_renderer_impl.h

diff --git a/media/renderers/video_renderer_impl.h b/media/renderers/video_renderer_impl.h

index 3938364eb1177efb3f1770984eee3123f931f31e..e35cc6e7ac14a5597a6b7909442526795420df69 100644

--- a/media/renderers/video_renderer_impl.h

+++ b/media/renderers/video_renderer_impl.h

@@ -70,7 +70,8 @@ class MEDIA_EXPORT VideoRendererImpl

const PipelineStatusCB& init_cb) override;

void Flush(const base::Closure& callback) override;

void StartPlayingFrom(base::TimeDelta timestamp) override;

- void OnTimeStateChanged(bool time_progressing) override;

+ void TimeStartedProgressing() override;

+ void TimeStoppedProgressing() override;

void SetTickClockForTesting(std::unique_ptr<base::TickClock> tick_clock);

void SetGpuMemoryBufferVideoForTesting(