Rename VideoRenderer::OnTimeStateChanged to OnTime{Progressing,Stopped}

Rename VideoRenderer::OnTimeStateChanged to OnTime{Progressing,Stopped}

This is a rename for readability + deletion of a couple of out of date comments.

Committed: https://crrev.com/fc7d98c133458cb429c5bdeaa9de8f8475bf6e37
Cr-Commit-Position: refs/heads/master@{#421323}

[watk, 2016-09-26 23:41:25]

Description was changed from

==========
Refactor VideoRenderer::OnTimeStateChanged(bool) to
Time{Started,Stopped}Progressing

This is a minor refactor to improve the readability of

BUG=
==========

to

==========
Refactor VideoRenderer::OnTimeStateChanged to Time{Started,Stopped}Progressing

This is a rename for readability + deletion of a couple of out of date comments.
==========

[watk, 2016-09-26 23:41:25]

watk@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[watk, 2016-09-26 23:42:37]

The CQ bit was checked by watk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 23:43:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 01:11:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 01:11:17]

Dry run: This issue passed the CQ dry run.

[DaleCurtis, 2016-09-27 17:12:26]

lgtm % naming. Actually I think the comment about not holding the lock is still
accurate, but only applies to calling StartSink() / StopSink(). Since either may
start or wait for Render() to complete.

https://codereview.chromium.org/2372863002/diff/20001/media/base/video_render...
File media/base/video_renderer.h (right):

https://codereview.chromium.org/2372863002/diff/20001/media/base/video_render...
media/base/video_renderer.h:58: virtual void TimeStartedProgressing() = 0;
OnTimeProgressing(), OnTimeStopped() ?

[watk, 2016-09-27 17:54:00]

Patchset #3 (id:40001) has been deleted

[watk, 2016-09-27 17:55:36]

What if I put On in front of them: OnTimeStartedProgressing
OnTimeStoppedProgressing? I like the symmetry. I'll wait for confirmation that
you're happy with the names. If not I'm fine with your suggestion.

I put the lock_ comment back for Start/Stop Sink().

[watk, 2016-09-27 17:55:45]

The CQ bit was checked by watk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 17:56:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[DaleCurtis, 2016-09-27 17:57:32]

They feel overly verbose and I don't them as such. If you like symmetry how
about dropping the word progressing? OnTimeStarted/OnTimeStopped.

[watk, 2016-09-27 18:12:44]

Description was changed from

==========
Refactor VideoRenderer::OnTimeStateChanged to Time{Started,Stopped}Progressing

This is a rename for readability + deletion of a couple of out of date comments.
==========

to

==========
Rename VideoRenderer::OnTimeStateChanged to OnTime{Progressing,Stopped}

This is a rename for readability + deletion of a couple of out of date comments.
==========

[watk, 2016-09-27 18:13:16]

The CQ bit was checked by watk@chromium.org

[watk, 2016-09-27 18:13:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/2372863002/#ps80001
(title: "suggestion")

[commit-bot: I haz the power, 2016-09-27 18:13:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 20:33:01]

Description was changed from

==========
Rename VideoRenderer::OnTimeStateChanged to OnTime{Progressing,Stopped}

This is a rename for readability + deletion of a couple of out of date comments.
==========

to

==========
Rename VideoRenderer::OnTimeStateChanged to OnTime{Progressing,Stopped}

This is a rename for readability + deletion of a couple of out of date comments.
==========

[commit-bot: I haz the power, 2016-09-27 20:33:02]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-09-27 20:34:31]

Description was changed from

==========
Rename VideoRenderer::OnTimeStateChanged to OnTime{Progressing,Stopped}

This is a rename for readability + deletion of a couple of out of date comments.
==========

to

==========
Rename VideoRenderer::OnTimeStateChanged to OnTime{Progressing,Stopped}

This is a rename for readability + deletion of a couple of out of date comments.

Committed: https://crrev.com/fc7d98c133458cb429c5bdeaa9de8f8475bf6e37
Cr-Commit-Position: refs/heads/master@{#421323}
==========

[commit-bot: I haz the power, 2016-09-27 20:34:32]

Patchset 4 (id:??) landed as
https://crrev.com/fc7d98c133458cb429c5bdeaa9de8f8475bf6e37
Cr-Commit-Position: refs/heads/master@{#421323}