[inspector] added inspector test runner [part 3]

[inspector] added inspector test runner [part 3]

- added test runner, that takes file names and V8 flags as arguments and run scripts from passed files with passed flags in frontend context

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/f3f9f4448dfa533d768878245a9bdbb57b4d941b
Committed: https://crrev.com/f0649c8f08536d469887fc73fb18c037f93f5cfd
Cr-Original-Commit-Position: refs/heads/master@{#39891}
Cr-Commit-Position: refs/heads/master@{#39929}

[kozy, 2016-09-26 21:03:26]

Dmitry, please take a look.

[kozy, 2016-09-27 20:48:44]

kozyatinskiy@chromium.org changed reviewers:
+ machenbach@chromium.org

[kozy, 2016-09-28 17:14:44]

Rebased, please take a look!

[dgozman, 2016-09-28 17:44:22]

https://codereview.chromium.org/2372793002/diff/60001/test/inspector-protocol...
File test/inspector-protocol/inspector-protocol.cc (right):

https://codereview.chromium.org/2372793002/diff/60001/test/inspector-protocol...
test/inspector-protocol/inspector-protocol.cc:156: new
ExecuteStringTask(v8_inspector::StringView(
StringView cannot outlive underlying String16.

[kozy, 2016-09-28 19:22:58]

All done, please take a look!

https://codereview.chromium.org/2372793002/diff/60001/test/inspector-protocol...
File test/inspector-protocol/inspector-protocol.cc (right):

https://codereview.chromium.org/2372793002/diff/60001/test/inspector-protocol...
test/inspector-protocol/inspector-protocol.cc:156: new
ExecuteStringTask(v8_inspector::StringView(
On 2016/09/28 17:44:22, dgozman wrote:
> StringView cannot outlive underlying String16.

Done.

[dgozman, 2016-09-28 21:03:08]

lgtm

https://codereview.chromium.org/2372793002/diff/80001/test/inspector-protocol...
File test/inspector-protocol/BUILD.gn (right):

https://codereview.chromium.org/2372793002/diff/80001/test/inspector-protocol...
test/inspector-protocol/BUILD.gn:7: v8_executable("inspector-protocol") {
Maybe inspector-protocol-test or inspector-test? It's a test executable after
all.

https://codereview.chromium.org/2372793002/diff/80001/test/inspector-protocol...
test/inspector-protocol/BUILD.gn:13: "inspector-protocol.cc",
inspector-test.cc

https://codereview.chromium.org/2372793002/diff/80001/test/inspector-protocol...
File test/inspector-protocol/inspector-impl.cc (right):

https://codereview.chromium.org/2372793002/diff/80001/test/inspector-protocol...
test/inspector-protocol/inspector-impl.cc:160: v8_inspector::String16
message_string(buffer.get(), message->Length());
I think we should introduce String16::createUninitialized to avoid copying in
this constructor. It's not critical here, but will speed up the inspector code.

https://codereview.chromium.org/2372793002/diff/80001/test/inspector-protocol...
File test/inspector-protocol/inspector-protocol.cc (right):

https://codereview.chromium.org/2372793002/diff/80001/test/inspector-protocol...
test/inspector-protocol/inspector-protocol.cc:124: CHECK(args.Length() == 2 &&
args[1]->IsNumber() && args[0]->IsFunction());
Let's print error message instead.

https://codereview.chromium.org/2372793002/diff/80001/test/inspector-protocol...
test/inspector-protocol/inspector-protocol.cc:127: CHECK(delay == 0.0);
ditto

https://codereview.chromium.org/2372793002/diff/80001/test/inspector-protocol...
test/inspector-protocol/inspector-protocol.cc:205: CHECK(exists);
Let's print error message instead of crashing.

[kozy, 2016-09-28 21:21:05]

Description was changed from

==========
[inspector] added inspector protocol test runner [part 3]

- added test runner, that takes file names and V8 flags as arguments and run
scripts from passed files with passed flags in frontend context

BUG=chromium:645640
R=dgozman@chromium.org,alph@chromium.org
==========

to

==========
[inspector] added inspector protocol test runner [part 3]

- added test runner, that takes file names and V8 flags as arguments and run
scripts from passed files with passed flags in frontend context

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org
==========

[kozy, 2016-09-28 22:12:00]

Patchset #6 (id:100001) has been deleted

[kozy, 2016-09-28 22:12:27]

All done. Thanks!

https://codereview.chromium.org/2372793002/diff/80001/test/inspector-protocol...
File test/inspector-protocol/BUILD.gn (right):

https://codereview.chromium.org/2372793002/diff/80001/test/inspector-protocol...
test/inspector-protocol/BUILD.gn:7: v8_executable("inspector-protocol") {
On 2016/09/28 21:03:08, dgozman wrote:
> Maybe inspector-protocol-test or inspector-test? It's a test executable after
> all.

Done in first part.

https://codereview.chromium.org/2372793002/diff/80001/test/inspector-protocol...
test/inspector-protocol/BUILD.gn:13: "inspector-protocol.cc",
On 2016/09/28 21:03:08, dgozman wrote:
> inspector-test.cc

Done.

https://codereview.chromium.org/2372793002/diff/80001/test/inspector-protocol...
File test/inspector-protocol/inspector-impl.cc (right):

https://codereview.chromium.org/2372793002/diff/80001/test/inspector-protocol...
test/inspector-protocol/inspector-impl.cc:160: v8_inspector::String16
message_string(buffer.get(), message->Length());
On 2016/09/28 21:03:08, dgozman wrote:
> I think we should introduce String16::createUninitialized to avoid copying in
> this constructor. It's not critical here, but will speed up the inspector
code.

I'll add it in separate CL.

https://codereview.chromium.org/2372793002/diff/80001/test/inspector-protocol...
File test/inspector-protocol/inspector-protocol.cc (right):

https://codereview.chromium.org/2372793002/diff/80001/test/inspector-protocol...
test/inspector-protocol/inspector-protocol.cc:124: CHECK(args.Length() == 2 &&
args[1]->IsNumber() && args[0]->IsFunction());
On 2016/09/28 21:03:08, dgozman wrote:
> Let's print error message instead.

Done.

https://codereview.chromium.org/2372793002/diff/80001/test/inspector-protocol...
test/inspector-protocol/inspector-protocol.cc:127: CHECK(delay == 0.0);
On 2016/09/28 21:03:08, dgozman wrote:
> ditto

Done.

https://codereview.chromium.org/2372793002/diff/80001/test/inspector-protocol...
test/inspector-protocol/inspector-protocol.cc:205: CHECK(exists);
On 2016/09/28 21:03:08, dgozman wrote:
> Let's print error message instead of crashing.

Done.

[kozy, 2016-09-28 22:20:05]

Patchset #6 (id:120001) has been deleted

[kozy, 2016-09-28 22:21:09]

Patchset #6 (id:140001) has been deleted

[kozy, 2016-09-29 05:20:45]

Description was changed from

==========
[inspector] added inspector protocol test runner [part 3]

- added test runner, that takes file names and V8 flags as arguments and run
scripts from passed files with passed flags in frontend context

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org
==========

to

==========
[inspector] added inspector test runner [part 3]

- added test runner, that takes file names and V8 flags as arguments and run
scripts from passed files with passed flags in frontend context

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org
==========

[alph, 2016-09-29 20:11:33]

lgtm

[kozy, 2016-09-29 21:41:09]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-09-29 21:41:10]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2372793002/#ps180001
(title: "fixed linter errors")

[commit-bot: I haz the power, 2016-09-29 21:41:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 21:42:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 21:42:50]

Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/13765)

[kozy, 2016-09-29 21:58:32]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-09-29 21:58:33]

The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org,
dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2372793002/#ps200001
(title: "rebased")

[commit-bot: I haz the power, 2016-09-29 21:58:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 22:23:31]

Description was changed from

==========
[inspector] added inspector test runner [part 3]

- added test runner, that takes file names and V8 flags as arguments and run
scripts from passed files with passed flags in frontend context

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org
==========

to

==========
[inspector] added inspector test runner [part 3]

- added test runner, that takes file names and V8 flags as arguments and run
scripts from passed files with passed flags in frontend context

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org
==========

[commit-bot: I haz the power, 2016-09-29 22:23:32]

Committed patchset #8 (id:200001)

[commit-bot: I haz the power, 2016-09-29 22:23:56]

Description was changed from

==========
[inspector] added inspector test runner [part 3]

- added test runner, that takes file names and V8 flags as arguments and run
scripts from passed files with passed flags in frontend context

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org
==========

to

==========
[inspector] added inspector test runner [part 3]

- added test runner, that takes file names and V8 flags as arguments and run
scripts from passed files with passed flags in frontend context

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/f3f9f4448dfa533d768878245a9bdbb57b4d941b
Cr-Commit-Position: refs/heads/master@{#39891}
==========

[commit-bot: I haz the power, 2016-09-29 22:23:57]

Patchset 8 (id:??) landed as
https://crrev.com/f3f9f4448dfa533d768878245a9bdbb57b4d941b
Cr-Commit-Position: refs/heads/master@{#39891}

[kozy, 2016-09-30 18:03:24]

Description was changed from

==========
[inspector] added inspector test runner [part 3]

- added test runner, that takes file names and V8 flags as arguments and run
scripts from passed files with passed flags in frontend context

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/f3f9f4448dfa533d768878245a9bdbb57b4d941b
Cr-Commit-Position: refs/heads/master@{#39891}
==========

to

==========
[inspector] added inspector test runner [part 3]

- added test runner, that takes file names and V8 flags as arguments and run
scripts from passed files with passed flags in frontend context

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/f3f9f4448dfa533d768878245a9bdbb57b4d941b
Cr-Commit-Position: refs/heads/master@{#39891}
==========

[kozy, 2016-10-02 17:08:58]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-02 17:09:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2016-10-02 17:09:18]

The CQ bit was unchecked by kozyatinskiy@chromium.org

[kozy, 2016-10-02 18:07:38]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-10-02 18:07:38]

The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org,
dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2372793002/#ps220001
(title: "added missing header")

[commit-bot: I haz the power, 2016-10-02 18:07:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-02 18:10:31]

Description was changed from

==========
[inspector] added inspector test runner [part 3]

- added test runner, that takes file names and V8 flags as arguments and run
scripts from passed files with passed flags in frontend context

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/f3f9f4448dfa533d768878245a9bdbb57b4d941b
Cr-Commit-Position: refs/heads/master@{#39891}
==========

to

==========
[inspector] added inspector test runner [part 3]

- added test runner, that takes file names and V8 flags as arguments and run
scripts from passed files with passed flags in frontend context

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/f3f9f4448dfa533d768878245a9bdbb57b4d941b
Cr-Commit-Position: refs/heads/master@{#39891}
==========

[commit-bot: I haz the power, 2016-10-02 18:10:32]

Committed patchset #9 (id:220001)

[commit-bot: I haz the power, 2016-10-02 18:10:45]

Description was changed from

==========
[inspector] added inspector test runner [part 3]

- added test runner, that takes file names and V8 flags as arguments and run
scripts from passed files with passed flags in frontend context

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/f3f9f4448dfa533d768878245a9bdbb57b4d941b
Cr-Commit-Position: refs/heads/master@{#39891}
==========

to

==========
[inspector] added inspector test runner [part 3]

- added test runner, that takes file names and V8 flags as arguments and run
scripts from passed files with passed flags in frontend context

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/f3f9f4448dfa533d768878245a9bdbb57b4d941b
Committed: https://crrev.com/f0649c8f08536d469887fc73fb18c037f93f5cfd
Cr-Original-Commit-Position: refs/heads/master@{#39891}
Cr-Commit-Position: refs/heads/master@{#39929}
==========

[commit-bot: I haz the power, 2016-10-02 18:10:46]

Patchset 9 (id:??) landed as
https://crrev.com/f0649c8f08536d469887fc73fb18c037f93f5cfd
Cr-Commit-Position: refs/heads/master@{#39929}