[inspector] added inspector test runner [part 3]

test/inspector-protocol/inspector-impl.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "test/inspector-protocol/inspector-impl.h"
 
 #include "include/v8.h"
 #include "src/inspector/string-16.h"
 
 namespace {
@@ skipping 14 matching lines @@
   void sendProtocolNotification(
       const v8_inspector::StringView& message) override {
     frontend_channel_->SendMessageToFrontend(message);
   }
   void flushProtocolNotifications() override {}
 
   InspectorClientImpl::FrontendChannel* frontend_channel_;
   DISALLOW_COPY_AND_ASSIGN(ChannelImpl);
 };
 
+InspectorClientImpl* InspectorClientFromContext(
+    v8::Local<v8::Context> context) {
+  InspectorClientImpl* inspector_client = static_cast<InspectorClientImpl*>(
+      context->GetAlignedPointerFromEmbedderData(kInspectorClientIndex));
+  CHECK(inspector_client);
+  return inspector_client;
+}
+
 }  //  namespace
 
 class ConnectTask : public TaskRunner::Task {
  public:
   ConnectTask(InspectorClientImpl* client, v8::base::Semaphore* ready_semaphore)
       : client_(client), ready_semaphore_(ready_semaphore) {}
   virtual ~ConnectTask() {}
 
   bool is_inspector_task() final { return true; }
 
@@ skipping 44 matching lines @@
 }
 
 void InspectorClientImpl::runMessageLoopOnPause(int) {
   task_runner_->RunMessageLoop(true);
 }
 
 void InspectorClientImpl::quitMessageLoopOnPause() {
   task_runner_->QuitMessageLoop();
 }
 
+v8_inspector::V8Inspector* InspectorClientImpl::InspectorFromContext(
+    v8::Local<v8::Context> context) {
+  return InspectorClientFromContext(context)->inspector_.get();
+}
+
 v8_inspector::V8InspectorSession* InspectorClientImpl::SessionFromContext(
     v8::Local<v8::Context> context) {
-  InspectorClientImpl* inspector_client = static_cast<InspectorClientImpl*>(
-      context->GetAlignedPointerFromEmbedderData(kInspectorClientIndex));
-  CHECK(inspector_client);
-  return inspector_client->session_.get();
+  return InspectorClientFromContext(context)->session_.get();
 }
 
 class SendMessageToBackendTask : public TaskRunner::Task {
  public:
   SendMessageToBackendTask(const v8_inspector::String16& message)
       : message_(message) {}
 
   bool is_inspector_task() final { return true; }
 
   void Run(v8::Isolate* isolate,
@@ skipping 25 matching lines @@
 }
 
 void SendMessageToBackendExtension::SendMessageToBackend(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   CHECK(backend_task_runner_);
   CHECK(args.Length() == 1 && args[0]->IsString());
   v8::Local<v8::String> message = args[0].As<v8::String>();
   std::unique_ptr<uint16_t[]> buffer(new uint16_t[message->Length()]);
   message.As<v8::String>()->Write(reinterpret_cast<uint16_t*>(buffer.get()), 0,
                                   message->Length());
   v8_inspector::String16 message_string(buffer.get(), message->Length());

[dgozman, 2016/09/28 21:03:08]

I think we should introduce String16::createUninitialized to avoid copying in
this constructor. It's not critical here, but will speed up the inspector code.

[kozy, 2016/09/28 22:12:26]

I'll add it in separate CL.

   backend_task_runner_->Append(new SendMessageToBackendTask(message_string));
 }