Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: rlz/lib/lib_values.cc

Issue 237273002: Do not reserve an access point code for CHROME_IOS_RESERVED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: rlz/lib/lib_values.cc
diff --git a/rlz/lib/lib_values.cc b/rlz/lib/lib_values.cc
index 06113a8fc9277a0ef821e2de7a71e890899c4083..586194a7407a22d1a53fd997f5c0277367e5886a 100644
--- a/rlz/lib/lib_values.cc
+++ b/rlz/lib/lib_values.cc
@@ -99,7 +99,9 @@ const char* GetAccessPointName(AccessPoint point) {
case CHROMEOS_HOME_PAGE: return "CB";
case CHROMEOS_APP_LIST: return "CC";
case CHROME_IOS_OMNIBOX: return "C9";
- case CHROME_IOS_RESERVED: return "C0";
+ // Note: this enumeration does not correspond to a real access point and
+ // should never be used. Fails back to the default that raises an assert.
+ case CHROME_IOS_RESERVED: break;
Roger Tawa OOO till Jul 10th 2014/04/14 19:35:20 Or just remove lines 102-104 completely so that it
pkl (ping after 24h if needed) 2014/04/14 19:43:09 Compiler will fail because not all enum values are
case CHROME_APP_LIST: return "C7";
case CHROME_MAC_APP_LIST: return "C8";
case UNDEFINED_AP_Q: return "RQ";
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698