Do not reserve an access point code for CHROME_IOS_RESERVED

rlz/lib/lib_values.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Key and value names of the location of the RLZ shared state.
 
 #include "rlz/lib/lib_values.h"
 
 #include "base/strings/stringprintf.h"
 #include "rlz/lib/assert.h"
@@ skipping 81 matching lines @@
   case PARTNER_AP_2:                  return "V2";
   case PARTNER_AP_3:                  return "V3";
   case PARTNER_AP_4:                  return "V4";
   case PARTNER_AP_5:                  return "V5";
   case CHROME_MAC_OMNIBOX:            return "C5";
   case CHROME_MAC_HOME_PAGE:          return "C6";
   case CHROMEOS_OMNIBOX:              return "CA";
   case CHROMEOS_HOME_PAGE:            return "CB";
   case CHROMEOS_APP_LIST:             return "CC";
   case CHROME_IOS_OMNIBOX:            return "C9";
-  case CHROME_IOS_RESERVED:           return "C0";
+  // Note: this enumeration does not correspond to a real access point and
+  // should never be used. Fails back to the default that raises an assert.
+  case CHROME_IOS_RESERVED:           break;

[Roger Tawa OOO till Jul 10th, 2014/04/14 19:35:20]

Or just remove lines 102-104 completely so that it falls through?

[pkl (ping after 24h if needed), 2014/04/14 19:43:09]

Compiler will fail because not all enum values are listed and there's no
"default".

   case CHROME_APP_LIST:               return "C7";
   case CHROME_MAC_APP_LIST:           return "C8";
   case UNDEFINED_AP_Q:                return "RQ";
   case UNDEFINED_AP_R:                return "RR";
   case UNDEFINED_AP_S:                return "RS";
   case UNDEFINED_AP_T:                return "RT";
   case UNDEFINED_AP_U:                return "RU";
   case UNDEFINED_AP_V:                return "RV";
   case UNDEFINED_AP_W:                return "RW";
   case UNDEFINED_AP_X:                return "RX";
@@ skipping 86 matching lines @@
   case WEBAPPS:          return "W";
   case PINYIN_IME:       return "N";
   case PARTNER:          return "V";
   }
 
   ASSERT_STRING("GetProductName: Unknown Product");
   return "";
 }
 
 }  // namespace rlz_lib