Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2372703006: Also dump a stack trace on a pthread assertion failure (Closed)

Created:
4 years, 2 months ago by Cutch
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Also dump a stack trace on a pthread assertion failure Recently on the build bots we hit a pthread_error (https://build.chromium.org/p/client.dart/builders/vm-linux-debug-x64-reload-be/builds/337/steps/vm%20tests/logs/stdio) but that code uses a different ASSERT macro so we don't get to see the stack trace. BUG= R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/a7fe93b62cfb77b02540dd95ef661c5cd8b44f6b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M runtime/vm/os_thread_android.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/os_thread_linux.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/os_thread_macos.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Cutch
4 years, 2 months ago (2016-09-27 18:04:49 UTC) #3
Florian Schneider
lgtm
4 years, 2 months ago (2016-09-27 18:15:33 UTC) #4
Cutch
Committed patchset #1 (id:1) manually as a7fe93b62cfb77b02540dd95ef661c5cd8b44f6b (presubmit successful).
4 years, 2 months ago (2016-09-27 18:16:35 UTC) #6
rmacnak
4 years, 2 months ago (2016-09-27 18:18:40 UTC) #7
Message was sent while issue was closed.
Stack dumps are already printed for FATALs. I suspect there's no trace for that
run because a second crash occurred attempting to create the trace.

Powered by Google App Engine
This is Rietveld 408576698