Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Side by Side Diff: runtime/vm/os_thread_linux.cc

Issue 2372703006: Also dump a stack trace on a pthread assertion failure (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/os_thread_android.cc ('k') | runtime/vm/os_thread_macos.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "platform/globals.h" // NOLINT 5 #include "platform/globals.h" // NOLINT
6 6
7 #if defined(TARGET_OS_LINUX) 7 #if defined(TARGET_OS_LINUX)
8 8
9 #include "vm/os_thread.h" 9 #include "vm/os_thread.h"
10 10
11 #include <errno.h> // NOLINT 11 #include <errno.h> // NOLINT
12 #include <sys/resource.h> // NOLINT 12 #include <sys/resource.h> // NOLINT
13 #include <sys/syscall.h> // NOLINT 13 #include <sys/syscall.h> // NOLINT
14 #include <sys/time.h> // NOLINT 14 #include <sys/time.h> // NOLINT
15 15
16 #include "platform/assert.h" 16 #include "platform/assert.h"
17 #include "platform/signal_blocker.h" 17 #include "platform/signal_blocker.h"
18 #include "platform/utils.h" 18 #include "platform/utils.h"
19 19
20 #include "vm/profiler.h"
21
20 namespace dart { 22 namespace dart {
21 23
22 #define VALIDATE_PTHREAD_RESULT(result) \ 24 #define VALIDATE_PTHREAD_RESULT(result) \
23 if (result != 0) { \ 25 if (result != 0) { \
24 const int kBufferSize = 1024; \ 26 const int kBufferSize = 1024; \
25 char error_buf[kBufferSize]; \ 27 char error_buf[kBufferSize]; \
28 NOT_IN_PRODUCT(Profiler::DumpStackTrace(true /* native_stack_trace */)); \
26 FATAL2("pthread error: %d (%s)", result, \ 29 FATAL2("pthread error: %d (%s)", result, \
27 Utils::StrError(result, error_buf, kBufferSize)); \ 30 Utils::StrError(result, error_buf, kBufferSize)); \
28 } 31 }
29 32
30 33
31 #if defined(DEBUG) 34 #if defined(DEBUG)
32 #define ASSERT_PTHREAD_SUCCESS(result) VALIDATE_PTHREAD_RESULT(result) 35 #define ASSERT_PTHREAD_SUCCESS(result) VALIDATE_PTHREAD_RESULT(result)
33 #else 36 #else
34 // NOTE: This (currently) expands to a no-op. 37 // NOTE: This (currently) expands to a no-op.
35 #define ASSERT_PTHREAD_SUCCESS(result) ASSERT(result == 0) 38 #define ASSERT_PTHREAD_SUCCESS(result) ASSERT(result == 0)
(...skipping 412 matching lines...) Expand 10 before | Expand all | Expand 10 after
448 void Monitor::NotifyAll() { 451 void Monitor::NotifyAll() {
449 // When running with assertions enabled we track the owner. 452 // When running with assertions enabled we track the owner.
450 ASSERT(IsOwnedByCurrentThread()); 453 ASSERT(IsOwnedByCurrentThread());
451 int result = pthread_cond_broadcast(data_.cond()); 454 int result = pthread_cond_broadcast(data_.cond());
452 VALIDATE_PTHREAD_RESULT(result); 455 VALIDATE_PTHREAD_RESULT(result);
453 } 456 }
454 457
455 } // namespace dart 458 } // namespace dart
456 459
457 #endif // defined(TARGET_OS_LINUX) 460 #endif // defined(TARGET_OS_LINUX)
OLDNEW
« no previous file with comments | « runtime/vm/os_thread_android.cc ('k') | runtime/vm/os_thread_macos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698