Issue 2372703004: Don't reset parameters if we aborted preparsing, rebuild them from the params_ list

Issue 2372703004: Don't reset parameters if we aborted preparsing, rebuild them from the params_ list (Closed)

Created:
4 years, 2 months ago by Toon Verwaest

Modified:
4 years, 2 months ago

Reviewers:
marja

CC:
v8-reviews_googlegroups.com, vogelheim

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Don't reset parameters if we aborted preparsing, rebuild them from the params_ list BUG= Committed: https://crrev.com/c0ded71713e6eea7e317a56f9a15b874fb89a083 Cr-Commit-Position: refs/heads/master@{#39769}

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+980 lines, -14 lines)			Patch
M	src/ast/scopes.h	View	1 chunk	+1 line, -13 lines	0 comments	Download
M	src/ast/scopes.cc	View	1 chunk	+30 lines, -0 lines	0 comments	Download
M	src/parsing/parser.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
A	test/mjsunit/regress/regress-abort-preparsing-params.js	View	1 chunk	+946 lines, -0 lines	0 comments	Download

Total messages: 8 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372703004/1

4 years, 2 months ago (2016-09-27 12:33:23 UTC) #5

commit-bot: I haz the power

4 years, 2 months ago (2016-09-27 13:05:43 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c0ded71713e6eea7e317a56f9a15b874fb89a083
Cr-Commit-Position: refs/heads/master@{#39769}