Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: src/ast/scopes.h

Issue 2372703004: Don't reset parameters if we aborted preparsing, rebuild them from the params_ list (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/ast/scopes.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/scopes.h
diff --git a/src/ast/scopes.h b/src/ast/scopes.h
index 840c63944eb355ccfb5d4dbddee2c4a9128818f4..27b4e416842f62f5f87786e4778838b86ac657cb 100644
--- a/src/ast/scopes.h
+++ b/src/ast/scopes.h
@@ -808,19 +808,7 @@ class DeclarationScope : public Scope {
void AllocateParameterLocals();
void AllocateReceiver();
- void ResetAfterPreparsing() {
- // Reset all non-trivial members.
- decls_.Clear();
- locals_.Clear();
- params_.Clear();
- sloppy_block_function_map_.Clear();
- variables_.Clear();
- // Make sure we won't walk the scope tree from here on.
- inner_scope_ = nullptr;
- // Make sure we won't try to allocate the rest parameter. {params_} was
- // cleared above.
- has_rest_ = false;
- }
+ void ResetAfterPreparsing(bool aborted);
private:
void AllocateParameter(Variable* var, int index);
« no previous file with comments | « no previous file | src/ast/scopes.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698