chrome/browser/resources/settings/search_engines_page/search_engines_list.html - Issue 2372693002: MD Settings: Fix search engines page popup menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engines_list.html

Issue 2372693002: MD Settings: Fix search engines page popup menu. (Closed)

Patch Set: Fix clipping. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/search_engines_page/search_engine_entry.js ('K') | « chrome/browser/resources/settings/search_engines_page/search_engine_entry.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/search_engines_page/search_engines_list.html

diff --git a/chrome/browser/resources/settings/search_engines_page/search_engines_list.html b/chrome/browser/resources/settings/search_engines_page/search_engines_list.html

index 20a9316762f18aa0709e3cf36f59b9a5930f6fbd..befa23cfa0ca5658acd4502b9884a36ea241ba64 100644

--- a/chrome/browser/resources/settings/search_engines_page/search_engines_list.html

+++ b/chrome/browser/resources/settings/search_engines_page/search_engines_list.html

@@ -34,7 +34,7 @@

</style>

- <iron-list items="[[engines]]" selectable>

+ <iron-list items="[[engines]]" selectable scroll-target="outer">

dpapad 2016/09/26 18:10:49 This fixes the clipping of the menu by the iron-li

stevenjb 2016/09/26 22:45:20 Conveniently this should be redundant with the fix

<settings-search-engine-entry engine="[[item]]"

tabindex$="[[tabIndex]]">