Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1615)

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engine_entry.js

Issue 2372693002: MD Settings: Fix search engines page popup menu. (Closed)
Patch Set: Fix clipping. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/search_engines_page/search_engine_entry.js
diff --git a/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js b/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js
index 5a33a8757e30841460ad6fc62290b8e7da8d55bb..cad9521d8984766b0cac7b8073ad18a03f9124a5 100644
--- a/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js
+++ b/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js
@@ -6,6 +6,14 @@
* @fileoverview 'settings-search-engine-entry' is a component for showing a
* search engine with its name, domain and query URL.
*/
+(function() {
+/**
+ * The max z index assigned to a <settings-search-engine-entry> so far. Used to
+ * ensure that the popup menu is displayed correctly.
+ * @type {number}
+ */
+var maxZIndex = 0;
stevenjb 2016/09/26 22:45:20 Can this just be a member of the Polymer object in
+
Polymer({
is: 'settings-search-engine-entry',
@@ -68,6 +76,11 @@ Polymer({
},
/** @private */
+ onDotsTap_: function() {
+ this.style.zIndex = ++maxZIndex;
+ },
+
+ /** @private */
closePopupMenu_: function() {
this.$$('iron-dropdown').close();
},
@@ -82,3 +95,4 @@ Polymer({
return cr.icon.getFavicon(url || '');
},
});
+})();

Powered by Google App Engine
This is Rietveld 408576698