Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: components/browser_watcher/postmortem_report_collector.h

Issue 2372633002: Use the correct product/version for postmortem reports (Closed)
Patch Set: Direct access to GetExecutableVersionDetails via ChromePostmortemReportCollector Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_watcher/postmortem_report_collector.h
diff --git a/components/browser_watcher/postmortem_report_collector.h b/components/browser_watcher/postmortem_report_collector.h
index aa21e22683fd44a5ab9bd8451d0e07fb054599b9..777aa4f851812a41458ab25a94fe406362adfb6a 100644
--- a/components/browser_watcher/postmortem_report_collector.h
+++ b/components/browser_watcher/postmortem_report_collector.h
@@ -12,6 +12,7 @@
#include <memory>
#include <set>
+#include <string>
#include <vector>
#include "base/files/file.h"
@@ -56,6 +57,10 @@ class PostmortemReportCollector {
const std::set<base::FilePath>& excluded_debug_files,
crashpad::CrashReportDatabase* report_database);
+ virtual const std::string& GetProductName() = 0;
+ virtual const std::string& GetProductVersion() = 0;
+ virtual const std::string& GetProductChannel() = 0;
+
private:
FRIEND_TEST_ALL_PREFIXES(PostmortemReportCollectorTest,
GetDebugStateFilePaths);

Powered by Google App Engine
This is Rietveld 408576698