Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4714)

Unified Diff: chrome/chrome_watcher/BUILD.gn

Issue 2372633002: Use the correct product/version for postmortem reports (Closed)
Patch Set: Direct access to GetExecutableVersionDetails via ChromePostmortemReportCollector Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_watcher/BUILD.gn
diff --git a/chrome/chrome_watcher/BUILD.gn b/chrome/chrome_watcher/BUILD.gn
index 0d9265bd300b231f72c7f5421abad1bf3df09637..2bc822190205b4cced1e41896e01e7eb61d6d826 100644
--- a/chrome/chrome_watcher/BUILD.gn
+++ b/chrome/chrome_watcher/BUILD.gn
@@ -76,3 +76,18 @@ shared_library("chrome_watcher") {
configs -= [ "//build/config/win:console" ]
configs += [ "//build/config/win:windowed" ]
}
+
+static_library("chrome_postmortem_report_collector") {
grt (UTC plus 2) 2016/09/27 20:43:09 i'm wondering if this is the right thing. some que
manzagop (departed) 2016/09/28 16:29:17 Went with using a callback. Theoretically, the col
+ sources = [
+ "chrome_postmortem_report_collector.cc",
+ "chrome_postmortem_report_collector.h",
+ ]
+ deps = [
+ "//base",
+ "//chrome/install_static:install_static_util",
+ "//components/browser_watcher:postmortem_report_collector",
+ "//components/browser_watcher:stability_report_proto",
grt (UTC plus 2) 2016/09/27 20:43:09 this is an unfortunate side effect of making cprc
manzagop (departed) 2016/09/28 16:29:17 Acknowledged.
+ "//third_party/crashpad/crashpad/client",
+ "//third_party/crashpad/crashpad/util",
+ ]
+}

Powered by Google App Engine
This is Rietveld 408576698