Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: components/browser_watcher/postmortem_minidump_writer_win.cc

Issue 2372633002: Use the correct product/version for postmortem reports (Closed)
Patch Set: Address clang errors Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_watcher/postmortem_minidump_writer_win.cc
diff --git a/components/browser_watcher/postmortem_minidump_writer_win.cc b/components/browser_watcher/postmortem_minidump_writer_win.cc
index 3e6a2d8da31ab48add26dc3f16c5cffa87202aaa..4a61f1efb2f831e48ffb62d7e313939d8d589a2d 100644
--- a/components/browser_watcher/postmortem_minidump_writer_win.cc
+++ b/components/browser_watcher/postmortem_minidump_writer_win.cc
@@ -197,8 +197,10 @@ bool PostmortemMinidumpWriter::WriteDumpImpl(
// TODO(manzagop): use product and version from the stability report. The
// current executable's values are an (imperfect) proxy.
std::map<std::string, std::string> crash_keys = {
- {"product", minidump_info.product_name + "_Postmortem"},
- {"version", minidump_info.version_number}};
+ {"prod", minidump_info.product_name + "_Postmortem"},
+ {"ver", minidump_info.version_number},
+ {"channel", minidump_info.channel_name},
+ {"plat", minidump_info.platform}};
if (!AppendCrashpadInfo(minidump_info.client_id, minidump_info.report_id,
crash_keys))
return false;
@@ -403,6 +405,10 @@ void PostmortemMinidumpWriter::RegisterDirectoryEntry(uint32_t stream_type,
} // namespace
+MinidumpInfo::MinidumpInfo() {}
+
+MinidumpInfo::~MinidumpInfo() {}
+
bool WritePostmortemDump(base::PlatformFile minidump_file,
const StabilityReport& report,
const MinidumpInfo& minidump_info) {

Powered by Google App Engine
This is Rietveld 408576698