Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: components/browser_watcher/postmortem_minidump_writer.h

Issue 2372633002: Use the correct product/version for postmortem reports (Closed)
Patch Set: Address clang errors Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/browser_watcher/DEPS ('k') | components/browser_watcher/postmortem_minidump_writer_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/browser_watcher/postmortem_minidump_writer.h
diff --git a/components/browser_watcher/postmortem_minidump_writer.h b/components/browser_watcher/postmortem_minidump_writer.h
index 74297de45ebca86af8f5e30e59992b183b503ee6..28758f84a68a326124ecfa97447c0b7c2e7b9217 100644
--- a/components/browser_watcher/postmortem_minidump_writer.h
+++ b/components/browser_watcher/postmortem_minidump_writer.h
@@ -17,10 +17,21 @@ namespace browser_watcher {
// Minidump information required by the Crashpad reporter.
struct MinidumpInfo {
- crashpad::UUID client_id; // The client's identifier.
- crashpad::UUID report_id; // The report's identifier.
- std::string product_name; // The product name to be used by the reporter.
- std::string version_number; // The product's version number.
+ MinidumpInfo();
+ ~MinidumpInfo();
+
+ // Client and report identifiers, from the Crashpad database.
+ crashpad::UUID client_id;
+ crashpad::UUID report_id;
+
+ // Product name, version number and channel name from the executable's version
+ // resource.
+ std::string product_name;
+ std::string version_number;
+ std::string channel_name;
+
+ // The platform identifier (e.g. "Win32" or "Win64").
+ std::string platform;
};
// Write to |minidump_file| a minimal minidump that wraps |report|. Returns
« no previous file with comments | « components/browser_watcher/DEPS ('k') | components/browser_watcher/postmortem_minidump_writer_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698