Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 237263004: change 'char' to 'int8_t' (Closed)

Created:
6 years, 8 months ago by caryclark
Modified:
6 years, 8 months ago
Reviewers:
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

fix broken build change 'char' to 'int8_t' BUG=skia: NOTRY=true TBR=reed@google.com Committed: http://code.google.com/p/skia/source/detail?r=14186

Patch Set 1 #

Patch Set 2 : #if SK_DEBUG should be #ifdef SK_DEBUG (broke canary) #

Patch Set 3 : #if SK_DEBUG should be #ifdef SK_DEBUG (broke canary) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pathops/SkPathOpsPoint.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
caryclark
The CQ bit was checked by caryclark@google.com
6 years, 8 months ago (2014-04-14 18:20:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/237263004/1
6 years, 8 months ago (2014-04-14 18:21:06 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-14 18:21:07 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 8 months ago (2014-04-14 18:21:07 UTC) #4
caryclark
lgtm
6 years, 8 months ago (2014-04-14 18:25:18 UTC) #5
caryclark
The CQ bit was checked by caryclark@google.com
6 years, 8 months ago (2014-04-14 18:25:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/237263004/1
6 years, 8 months ago (2014-04-14 18:25:36 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-14 18:25:36 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 8 months ago (2014-04-14 18:25:37 UTC) #9
caryclark
The CQ bit was checked by caryclark@google.com
6 years, 8 months ago (2014-04-14 18:32:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/237263004/1
6 years, 8 months ago (2014-04-14 18:32:52 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-04-14 18:33:06 UTC) #12
Message was sent while issue was closed. 
Change committed as 14186

Powered by Google App Engine
This is Rietveld 408576698