src/pathops/SkPathOpsPoint.h - Issue 237263004: change 'char' to 'int8_t'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pathops/SkPathOpsPoint.h

Issue 237263004: change 'char' to 'int8_t' (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: #if SK_DEBUG should be #ifdef SK_DEBUG (broke canary) Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pathops/SkPathOpsPoint.h

diff --git a/src/pathops/SkPathOpsPoint.h b/src/pathops/SkPathOpsPoint.h

index 8fd247ee51888436196d44c0e562a5b39279f6cd..336fb62de083d3d8e3816b1ea0283ce5ac9fbb8c 100644

--- a/src/pathops/SkPathOpsPoint.h

+++ b/src/pathops/SkPathOpsPoint.h

@@ -148,7 +148,7 @@ struct SkDPoint {

return AlmostBequalUlps((double) largest, largest + dist); // is dist within ULPS tolerance?

}

-#if SK_DEBUG

+#ifdef SK_DEBUG

static bool RoughlyEqual(const SkPoint& a, const SkPoint& b) {

if (approximately_equal(a.fX, b.fX) && approximately_equal(a.fY, b.fY)) {

return true;

« no previous file with comments | « no previous file | no next file » | no next file with comments »