Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 23726050: Disable WebViewTest.Shim(resize-related) tests in software compositing mode. (Closed)

Created:
7 years, 3 months ago by gab
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, piman+watch_chromium.org, jam, apatrick_chromium, darin-cc_chromium.org
Visibility:
Public.

Description

Disable WebViewTest.Shim(resize-related) tests in software compositing mode. BUG=295801 R=fsamuel@chromium.org, jbauman@chromium.org, joi@chromium.org, zmo@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224807

Patch Set 1 #

Patch Set 2 : merge up to r224463 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -7 lines) Patch
M chrome/browser/apps/web_view_browsertest.cc View 1 5 chunks +31 lines, -0 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.h View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/public/browser/gpu_data_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
gab
John, does it make sense to you to expose this call in the public API? ...
7 years, 3 months ago (2013-09-20 19:55:16 UTC) #1
gab
+Fady who seems to know about WebViewTests :)!
7 years, 3 months ago (2013-09-20 20:14:05 UTC) #2
Fady Samuel
lgtm
7 years, 3 months ago (2013-09-20 20:16:26 UTC) #3
jbauman
On 2013/09/20 20:16:26, Fady Samuel wrote: > lgtm Yeah, I think it makes sense to ...
7 years, 3 months ago (2013-09-20 23:29:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/23726050/5001
7 years, 3 months ago (2013-09-21 03:19:39 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=26795
7 years, 3 months ago (2013-09-21 03:30:56 UTC) #6
gab
+joi for content/public changes +zmo for chrome/browser/gpu changes Thanks! Gab
7 years, 3 months ago (2013-09-21 03:59:30 UTC) #7
Jói
//content/public LGTM
7 years, 3 months ago (2013-09-23 12:27:17 UTC) #8
Zhenyao Mo
On 2013/09/23 12:27:17, Jói wrote: > //content/public LGTM content/browser/gpu LGTM
7 years, 3 months ago (2013-09-23 16:38:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/23726050/5001
7 years, 3 months ago (2013-09-23 19:21:40 UTC) #10
gab
7 years, 3 months ago (2013-09-23 22:09:07 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 manually as r224807 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698