Issue 23726017: Telemetry: Catch LookupError exception and mark as failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23726017: Telemetry: Catch LookupError exception and mark as failure. (Closed)

Created:
7 years, 3 months ago by Dominik Grewe

Modified:
7 years, 3 months ago

Reviewers:
bulach, dtu

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Telemetry: Catch LookupError exception and mark as failure. Because the smoothness measurement may throw LookupError exceptions, PageRunner::_RunPage() catches those and reports a failure. Before, this exception wasn't caught and thus caused Telemetry to crash. BUG=238864 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220977

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/telemetry/telemetry/page/page_runner.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominikg@chromium.org/23726017/1

7 years, 3 months ago (2013-09-03 14:35:13 UTC) #3

dtu

We don't want to catch all LookupErrors here, because it's a built-in Python exception. Instead, ...

7 years, 3 months ago (2013-09-03 19:30:23 UTC) #5

Dominik Grewe

7 years, 3 months ago (2013-09-04 16:49:11 UTC) #6

Message was sent while issue was closed.

On 2013/09/03 19:30:23, Dave Tu wrote:
> We don't want to catch all LookupErrors here, because it's a built-in Python
> exception. Instead, we should make smoothness throw an Error that subclasses
> page_test.Failure.

I agree, good point. I'll upload a new CL.

Expand Messages | Collapse Messages