tools/telemetry/telemetry/page/page_runner.py - Issue 23726017: Telemetry: Catch LookupError exception and mark as failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 23726017: Telemetry: Catch LookupError exception and mark as failure. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/page_runner.py

diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py

index de0ebffc82bc9513000be2fd80347580a3260e2b..0cd182632276bd55b37c886987609ed7459a1207 100644

--- a/tools/telemetry/telemetry/page/page_runner.py

+++ b/tools/telemetry/telemetry/page/page_runner.py

@@ -391,7 +391,7 @@ def _RunPage(test, page, state, expectation, results, finder_options):

page_state.ImplicitPageNavigation(page, tab, test)

test.Run(finder_options, page, tab, results)

util.CloseConnections(tab)

- except page_test.Failure:

+ except (page_test.Failure, LookupError):

logging.warning('%s:\n%s', page.url, traceback.format_exc())

if expectation == 'fail':

logging.info('Failure was expected\n')

« no previous file with comments | « no previous file | no next file » | no next file with comments »