Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2372593003: Iterative cleanup for GL programs in GPU process (Closed)

Created:
4 years, 2 months ago by ericrk
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Iterative cleanup for GL programs in GPU process Currently, when we destroy a GPU channel, we delete all programs in a single operation. This operation can be moderately expensive, and on very overloaded systems (and with enough programs), may take more than the 10s given to a task by the GPU watchdog. This change allows programs to be iteratively deleted over several tasks, allowing other GPU operations and IPCs to be processed, and preventing us from timing out the watchdog timer. This is an experimental CL to see if the crash rates in crbug.com/612219 are addressed. If so, more cleanup and additional iterative deletion will be added. BUG=612219 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Patch Set 1 #

Patch Set 2 : feedback #

Patch Set 3 : fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -1 line) Patch
M gpu/command_buffer/service/program_manager.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 1 1 chunk +17 lines, -0 lines 0 comments Download
M gpu/ipc/service/gpu_channel.h View 1 2 3 chunks +16 lines, -0 lines 0 comments Download
M gpu/ipc/service/gpu_channel.cc View 1 2 chunks +37 lines, -0 lines 0 comments Download
M gpu/ipc/service/gpu_channel_manager.h View 1 2 4 chunks +6 lines, -0 lines 0 comments Download
M gpu/ipc/service/gpu_channel_manager.cc View 1 2 chunks +33 lines, -1 line 0 comments Download

Messages

Total messages: 20 (18 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372593003/60001
4 years, 2 months ago (2016-09-27 20:16:18 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 20:16:20 UTC) #20
No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698