Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2388)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java

Issue 2372313002: [Download Home] More effectively disable Download Home (Closed)
Patch Set: Rebasing Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
index 99a7079aaa31b62956c9c17a896898cdc3063162..d51ad82ba811c933e6fd2151e57516104b3a775d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
@@ -4,7 +4,6 @@
package org.chromium.chrome.browser.download;
-import android.app.Activity;
import android.app.DownloadManager;
import android.content.ActivityNotFoundException;
import android.content.BroadcastReceiver;
@@ -22,8 +21,6 @@ import android.text.TextUtils;
import android.util.LongSparseArray;
import android.util.Pair;
-import org.chromium.base.ActivityState;
-import org.chromium.base.ApplicationStatus;
import org.chromium.base.ContextUtils;
import org.chromium.base.Log;
import org.chromium.base.ObserverList;
@@ -33,7 +30,6 @@ import org.chromium.base.annotations.CalledByNative;
import org.chromium.base.annotations.SuppressFBWarnings;
import org.chromium.base.metrics.RecordHistogram;
import org.chromium.chrome.R;
-import org.chromium.chrome.browser.ChromeActivity;
import org.chromium.chrome.browser.download.ui.BackendProvider;
import org.chromium.chrome.browser.download.ui.DownloadHistoryAdapter;
import org.chromium.chrome.browser.externalnav.ExternalNavigationDelegateImpl;
@@ -1063,17 +1059,7 @@ public class DownloadManagerService extends BroadcastReceiver implements
* @param context Application context
*/
protected static void openDownloadsPage(Context context) {
- // Try to open Download Home.
- Activity lastActivity = ApplicationStatus.getLastTrackedFocusedActivity();
- if (lastActivity instanceof ChromeActivity) {
- int state = ApplicationStatus.getStateForActivity(lastActivity);
- if (state >= ActivityState.CREATED && state <= ActivityState.RESUMED) {
- ChromeActivity chromeActivity = (ChromeActivity) lastActivity;
- DownloadUtils.showDownloadManager(
- lastActivity, chromeActivity.getActivityTab());
- return;
- }
- }
+ if (DownloadUtils.showDownloadManager(null, null)) return;
// Open the Android Download Manager.
Intent pageView = new Intent(DownloadManager.ACTION_VIEW_DOWNLOADS);

Powered by Google App Engine
This is Rietveld 408576698