Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2372223002: Remove the unused browsing_data_ui/ component. (Closed)

Created:
4 years, 2 months ago by msramek
Modified:
4 years, 2 months ago
Reviewers:
msarda, blundell
CC:
chromium-reviews, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the unused browsing_data_ui/ component. Its contents were moved to the browsing_data/ component in https://codereview.chromium.org/2238453002, but the directory itself and the DEPS file in it were accidentally left behind. BUG=635873 Committed: https://crrev.com/a765fb3e033592f5cfaea2a29f088622a66d62b3 Cr-Commit-Position: refs/heads/master@{#421199}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
D components/browsing_data_ui/DEPS View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
msramek
Hi Mihai, sorry for the déjà vu, apparently I handled the deleted files wrongly when ...
4 years, 2 months ago (2016-09-27 13:56:31 UTC) #4
msramek
...actually, the OWNERS file *was* correctly deleted, so you cannot give me LGTM :-D +Colin, ...
4 years, 2 months ago (2016-09-27 13:57:55 UTC) #6
blundell
lgtm
4 years, 2 months ago (2016-09-27 14:05:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372223002/1
4 years, 2 months ago (2016-09-27 14:24:33 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 14:29:35 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 14:31:50 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a765fb3e033592f5cfaea2a29f088622a66d62b3
Cr-Commit-Position: refs/heads/master@{#421199}

Powered by Google App Engine
This is Rietveld 408576698