Merge //components/browsing_data_ui into //components/browsing_data/core

Merge //components/browsing_data_ui into //components/browsing_data/core

The component browsing_data_ui contains code used by the Clear Browsing
Data dialog on all platforms. It was created because there was no other
component fitting that purpose.

However, the browsing_data component has been recently made into a layered
component (https://codereview.chromium.org/2127403002), providing various
browsing data related functionality for all platforms.

Since the two components have basically the same purpose and confusingly
similar names, we merge them into one.

TBR=dbeam@chromium.org
BUG=635873
Committed: https://crrev.com/c153a25112aa4aa30eacac463c1fc0b2d9b4f52e
Cr-Commit-Position: refs/heads/master@{#419450}

[msramek, 2016-08-10 12:08:16]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 12:08:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 12:57:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 12:57:58]

Dry run: This issue passed the CQ dry run.

[msramek, 2016-08-19 12:35:07]

msramek@chromium.org changed reviewers:
+ msarda@chromium.org

[msramek, 2016-08-19 12:35:08]

Hi Mihai,

Would you be OK with this clean-up, or do you think it makes sense to keep the
components separate?

Thanks,
Martin

[msramek, 2016-09-13 15:00:08]

Friendly ping :-) What do you think about this kind of cleanup, Mihai?

[msramek, 2016-09-14 11:21:43]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 11:21:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 11:24:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 11:24:26]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[msramek, 2016-09-14 11:36:09]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 11:36:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 12:38:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 12:38:39]

Dry run: This issue passed the CQ dry run.

[msarda, 2016-09-15 08:51:18]

On 2016/09/13 15:00:08, msramek wrote:
> Friendly ping :-) What do you think about this kind of cleanup, Mihai?

LGTM

As discussed off-line, this will impact downstream Chorme iOS. Please wait until
the downstream path is ready before landing this CL.

[msramek, 2016-09-15 09:35:32]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 09:35:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msramek, 2016-09-15 09:54:42]

msramek@chromium.org changed reviewers:
+ cbentzel@chromium.org, pavely@chromium.org, rogerta@chromium.org,
sdefresne@chromium.org, sky@chromium.org

[msramek, 2016-09-15 09:54:43]

Most changes are in includes and namespace names, so I would TBR them. The
important thing are newly added DEPS.

Merging the two components carries over history-sync-related dependencies into
browsing_data/core. That should be semantically correct, as browsing_data/ is
supposed to be somewhat higher level and understand that there is something
called history and that it can be synced.

+sdefresne@ PTAL at history
+pavely@ PTAL at sync and browser_sync
+sky@ PTAL at version_info
+rogerta@ PTAL at signin
+cbentzel@ PTAL at net

[commit-bot: I haz the power, 2016-09-15 10:32:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 10:32:58]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2016-09-15 11:25:47]

lgtm

[cbentzel, 2016-09-15 13:56:37]

On 2016/09/15 11:25:47, sdefresne wrote:
> lgtm

lgtm for net/ DEPS

[Roger Tawa OOO till Jul 10th, 2016-09-15 15:01:19]

lgtm for components/browsing_data/core/DEPS on component/signin

[sky, 2016-09-15 17:12:17]

On 2016/09/15 09:54:43, msramek wrote:
> Most changes are in includes and namespace names, so I would TBR them. The
> important thing are newly added DEPS.
> 
> Merging the two components carries over history-sync-related dependencies into
> browsing_data/core. That should be semantically correct, as browsing_data/ is
> supposed to be somewhat higher level and understand that there is something
> called history and that it can be synced.
> 
> +sdefresne@ PTAL at history
> +pavely@ PTAL at sync and browser_sync
> +sky@ PTAL at version_info

I don't see any changes to version_info. Am I missing something?

> +rogerta@ PTAL at signin
> +cbentzel@ PTAL at net

[msramek, 2016-09-15 17:18:51]

On 2016/09/15 17:12:17, sky wrote:
> On 2016/09/15 09:54:43, msramek wrote:
> > Most changes are in includes and namespace names, so I would TBR them. The
> > important thing are newly added DEPS.
> > 
> > Merging the two components carries over history-sync-related dependencies
into
> > browsing_data/core. That should be semantically correct, as browsing_data/
is
> > supposed to be somewhat higher level and understand that there is something
> > called history and that it can be synced.
> > 
> > +sdefresne@ PTAL at history
> > +pavely@ PTAL at sync and browser_sync
> > +sky@ PTAL at version_info
> 
> I don't see any changes to version_info. Am I missing something?

It's just about the added dependency. Recently WebHistoryService has been
changed to talk directly to one of sync endpoints, where we need version_info to
contact the correct sync server (there's one for stable/beta and one for the
rest). This dependency was now carried over to history_notice_utils_unittest.cc
together with the dependencies on history and sync.

> 
> > +rogerta@ PTAL at signin
> > +cbentzel@ PTAL at net

[pavely, 2016-09-15 17:45:01]

deps on components/sync and components/browser_sync lgtm

[sky, 2016-09-15 20:06:04]

LGTM

[msramek, 2016-09-19 12:42:13]

Description was changed from

==========
Merge //components/browsing_data_ui into //components/browsing_data/core

The component browsing_data_ui contains code used by the Clear Browsing
Data dialog on all platforms. It was created because there was no other
component fitting that purpose.

However, the browsing_data component has been recently made into a layered
component (https://codereview.chromium.org/2127403002), providing various
browsing data related functionality for all platforms.

Since the two components have basically the same purpose and confusingly
similar names, we merge them into one.

BUG=635873
==========

to

==========
Merge //components/browsing_data_ui into //components/browsing_data/core

The component browsing_data_ui contains code used by the Clear Browsing
Data dialog on all platforms. It was created because there was no other
component fitting that purpose.

However, the browsing_data component has been recently made into a layered
component (https://codereview.chromium.org/2127403002), providing various
browsing data related functionality for all platforms.

Since the two components have basically the same purpose and confusingly
similar names, we merge them into one.

TBR=dbeam@chromium.org
BUG=635873
==========

[msramek, 2016-09-19 12:42:13]

msramek@chromium.org changed reviewers:
+ dbeam@chromium.org

[msramek, 2016-09-19 12:43:41]

Thanks everyone!

Also adding +dbeam@ to TBR for the syntactic changes in webui/ (header and
namespace updates).

And proceeding to land this in conjunction with the iOS downstream...

[msramek, 2016-09-19 12:44:00]

The CQ bit was checked by msramek@chromium.org

[msramek, 2016-09-19 12:44:01]

The patchset sent to the CQ was uploaded after l-g-t-m from msarda@chromium.org
Link to the patchset: https://codereview.chromium.org/2238453002/#ps60001
(title: "Accidentally added an old .gypi file.")

[commit-bot: I haz the power, 2016-09-19 12:44:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 12:46:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 12:46:58]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[msramek, 2016-09-19 12:57:28]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 12:57:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msramek, 2016-09-19 13:12:07]

Rebased over https://codereview.chromium.org/2345843003/ which required a DEPS
update "browser_sync/browser" -> "browser_sync/".

Trying again...

[msramek, 2016-09-19 13:13:07]

The CQ bit was unchecked by msramek@chromium.org

[msramek, 2016-09-19 13:13:13]

The CQ bit was checked by msramek@chromium.org

[msramek, 2016-09-19 13:13:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbentzel@chromium.org, rogerta@chromium.org, sky@chromium.org,
pavely@chromium.org, sdefresne@chromium.org, msarda@chromium.org
Link to the patchset: https://codereview.chromium.org/2238453002/#ps80001
(title: "Rebase over https://codereview.chromium.org/2345843003/")

[commit-bot: I haz the power, 2016-09-19 13:13:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 14:18:57]

Description was changed from

==========
Merge //components/browsing_data_ui into //components/browsing_data/core

The component browsing_data_ui contains code used by the Clear Browsing
Data dialog on all platforms. It was created because there was no other
component fitting that purpose.

However, the browsing_data component has been recently made into a layered
component (https://codereview.chromium.org/2127403002), providing various
browsing data related functionality for all platforms.

Since the two components have basically the same purpose and confusingly
similar names, we merge them into one.

TBR=dbeam@chromium.org
BUG=635873
==========

to

==========
Merge //components/browsing_data_ui into //components/browsing_data/core

The component browsing_data_ui contains code used by the Clear Browsing
Data dialog on all platforms. It was created because there was no other
component fitting that purpose.

However, the browsing_data component has been recently made into a layered
component (https://codereview.chromium.org/2127403002), providing various
browsing data related functionality for all platforms.

Since the two components have basically the same purpose and confusingly
similar names, we merge them into one.

TBR=dbeam@chromium.org
BUG=635873
==========

[commit-bot: I haz the power, 2016-09-19 14:18:58]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-19 14:20:54]

Description was changed from

==========
Merge //components/browsing_data_ui into //components/browsing_data/core

The component browsing_data_ui contains code used by the Clear Browsing
Data dialog on all platforms. It was created because there was no other
component fitting that purpose.

However, the browsing_data component has been recently made into a layered
component (https://codereview.chromium.org/2127403002), providing various
browsing data related functionality for all platforms.

Since the two components have basically the same purpose and confusingly
similar names, we merge them into one.

TBR=dbeam@chromium.org
BUG=635873
==========

to

==========
Merge //components/browsing_data_ui into //components/browsing_data/core

The component browsing_data_ui contains code used by the Clear Browsing
Data dialog on all platforms. It was created because there was no other
component fitting that purpose.

However, the browsing_data component has been recently made into a layered
component (https://codereview.chromium.org/2127403002), providing various
browsing data related functionality for all platforms.

Since the two components have basically the same purpose and confusingly
similar names, we merge them into one.

TBR=dbeam@chromium.org
BUG=635873

Committed: https://crrev.com/c153a25112aa4aa30eacac463c1fc0b2d9b4f52e
Cr-Commit-Position: refs/heads/master@{#419450}
==========

[commit-bot: I haz the power, 2016-09-19 14:20:56]

Patchset 5 (id:??) landed as
https://crrev.com/c153a25112aa4aa30eacac463c1fc0b2d9b4f52e
Cr-Commit-Position: refs/heads/master@{#419450}