Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 2372103004: [Devtools][UI] Dark theme better color for ContentLoaded (Closed)

Created:
4 years, 2 months ago by allada
Modified:
4 years, 2 months ago
Reviewers:
chowse, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools][UI] Dark theme better color for ContentLoaded Addes a slight better color variatin for dark theme when displaying DOMContentLoaded value in network panel. Screenshots: http://imgur.com/a/qdgC8 R=lushnikov BUG=641408 Committed: https://crrev.com/a63d791b7c85a9ebf9531fb964c94ea15343c71e Cr-Commit-Position: refs/heads/master@{#421880}

Patch Set 1 #

Patch Set 2 : [Devtools][UI] Dark theme better color for ContentLoaded #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/networkLogView.css View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
allada
PTL
4 years, 2 months ago (2016-09-27 22:16:06 UTC) #1
lushnikov
over to @chowse also, you can create specialized rules for dark theme with the .-theme-with-dark-background ...
4 years, 2 months ago (2016-09-28 16:20:27 UTC) #3
chowse1
On 2016/09/28 16:20:27, lushnikov wrote: > over to @chowse > > also, you can create ...
4 years, 2 months ago (2016-09-28 18:37:37 UTC) #4
allada
PTL
4 years, 2 months ago (2016-09-29 00:25:14 UTC) #6
lushnikov
lgtm nit: you probably want screenshot links to be in CL comments rather then in ...
4 years, 2 months ago (2016-09-29 16:07:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372103004/20001
4 years, 2 months ago (2016-09-29 17:06:28 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-29 18:38:17 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 18:41:19 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a63d791b7c85a9ebf9531fb964c94ea15343c71e
Cr-Commit-Position: refs/heads/master@{#421880}

Powered by Google App Engine
This is Rietveld 408576698