Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2372083002: Revert of My take on SkAlign changes. (Closed)

Created:
4 years, 2 months ago by mtklein
Modified:
4 years, 2 months ago
Reviewers:
cblume, mtklein_C
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of My take on SkAlign changes. (patchset #3 id:40001 of https://codereview.chromium.org/2368293002/ ) Reason for revert: Let's see if reverting this helps the roll. Original issue's description: > My take on SkAlign changes. > > Like the other change, it makes SkAlignN(x) macros work for pointers, and makes the macros themselves just syntax sugar for SkAlign<N>(x). We can still decide if we want to sed away the macros independently. > > This just does it in a somewhat less repetitive way, and adds some tests. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368293002 > > No public API changes. > TBR=reed@google.com > > Committed: https://skia.googlesource.com/skia/+/e1a5f4e292384046678edc5c1e360b3e13dc118c TBR=cblume@chromium.org,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/6a259bfcc80a7b4765b99c7503e5a5b98b7e1523

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -57 lines) Patch
M include/core/SkTypes.h View 1 chunk +14 lines, -39 lines 0 comments Download
M tests/MathTest.cpp View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
mtklein
Created Revert of My take on SkAlign changes.
4 years, 2 months ago (2016-09-27 01:20:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372083002/1
4 years, 2 months ago (2016-09-27 01:20:53 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 01:21:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6a259bfcc80a7b4765b99c7503e5a5b98b7e1523

Powered by Google App Engine
This is Rietveld 408576698